Ctrlpanel-gg / panel

CtrlPanel offers an easy-to-use and free billing solution for all starting and experienced hosting providers that seamlessly integrates with the Pterodactyl panel.
https://ctrlpanel.gg/
MIT License
408 stars 146 forks source link

[Bug]: Inconsistencies in role names. #958

Open kenshin133 opened 4 months ago

kenshin133 commented 4 months ago

What is your request about?

403 USER DOES NOT HAVE THE RIGHT PERMISSIONS.

was found while trying to add sane permissions for the "support staff" role.

I notice the error I see is that admin.tickets.read is missing, but that perm does not exist. I DO have admin.ticket.read

image

Branch

dev

Solution idea

I think a sweeping change to make sure some of these are standardized should do it. it looks like logic wise its working. but just the wrong name.

The SPECIFIC fix for this one would be in Http/Controllers/Admin/TicketsController.php

This inconsistency also goes as far as the database

image

Ctrlpanel Logs

no logs needed

Additional Info

UPDATE permissions SET name="admin.tickets.read" where id=6; plus changing all instances of admin.ticket.read in all files fixed this. ily