search

CuBoulder / express_mono

Monolithic Express Profile - contains all bundles
GNU General Public License v2.0
1 stars 2 forks source link

Replace Travis CI with GitHub Actions #822

Closed AlanBCole closed 3 years ago

github-actions[bot] commented 3 years ago

Run Tests When Work Is Completed

Do not merge code before you run tests. Do the following when you have completed work on this PR and all of you reviewers have approved it:

  1. Add the Label "ReadyForTesting"
  2. If the tests pass please merge it!
  3. If the tests fail. You have more work to do!
AlanBCole commented 3 years ago

In order to run tests you need to add the "ReadyForTesting" label. This will trigger a full run of our Behat test suite.

When a new PR is created the "Run Tests..." comment you see above is created. No test are run until the label just mentioned is added. Each run takes 10-15 minutes so I wanted to find a way to reduce the amount of times tests were run.

AlanBCole commented 3 years ago

@cathysnider Would it be ok if I changed the text to:

  1. Add the label "ReadyForTesting".
  2. If the tests pass:
    • Great!
    • Wait for you reviewers to approve the PR.
    • Merge when appropriate.
  3. If the tests fail:
    • You have more work to do!
    • Take the label off.
    • Make your changes.
    • Repeat these steps.
cathysnider commented 3 years ago

@AlanBCole That sounds great!