search

CuBoulder / express_mono

Monolithic Express Profile - contains all bundles
GNU General Public License v2.0
1 stars 2 forks source link

Block Designer Theme creation bug #833

Closed ekellagher closed 3 years ago

ekellagher commented 3 years ago

If a site does not have any Block Designer Themes, A Site Editor may click on the block designer tab and click the "Create a Block Designer Theme" link and create a new theme.

SE add theme

Once a Theme has been created though they are unable to edit the theme or go to the Design Admin page.

SE create new theme
cathysnider commented 3 years ago

Two options:

1. Remove ability to add Block Designer themes: According to the User Roles master plan, Site Editors do not make decisions on the design of the site. That ability belongs to the Site Owners. See User Roles 3.0 https://docs.google.com/spreadsheets/d/1fJk-k9BUySz3a7tMpMvEKKRfcToGeER1MBLajKxFi6s/edit#gid=0

Therefore, the ability to access the Block Designer Theme page should be removed from the Site Editor role.

Edit: To complete this, remove permission 'administer block designer themes' from site_editor array. https://github.com/CuBoulder/express_mono/blob/dev/modules/custom/express_block_designer/express_block_designer.module#L190

2. Add ability to access all themes: The other option is to add the permission 'administer express theme picker' to the Site Editor role. This would expand the abilities currently assigned to the Site Editor role, allowing them to administer WebExp Themes.

cathysnider commented 3 years ago

I checked with Emily about the level of access for Site Editors. She confirmed: "Site Editors should not be able to create block designer themes, they can design blocks individually but not create universal site block themes."