search

CuBoulder / tiamat-theme

University of Colorado Boulder Drupal 9+ base theme
GNU General Public License v2.0
3 stars 0 forks source link

Image Styles Across Blocks #1249

Open jnicholCU opened 2 weeks ago

jnicholCU commented 2 weeks ago

Across our blocks there are instances of using CSS for cropping rather than using image styles. This causes a disconnect in the migration process for how things look visually.

We are already passing all information about focal cropping thru our migration so we should be using that properly for these cropped styles

Some examples from Kevin: https://live-ucbprod-biofrontiers.pantheonsite.io/idea vs https://www.colorado.edu/biofrontiers/idea

https://live-ucbprod-biofrontiers.pantheonsite.io/sites/default/files/styles/focal_image_square/public/article-thumbnail/website.jpg?h=ba84b594&itok=BN6xEbV2 vs https://www.colorado.edu/biofrontiers/sites/default/files/styles/large_wide_thumbnail/public/article-thumbnail/website.jpg?itok=2iyYuxq0

jnicholCU commented 2 weeks ago

I'm already working on changes in this vein for the Slider image styles. I've found ways to correctly target parent templates as need for instances where we didn't think it was possible before, hence the use of CSS.

jnicholCU commented 2 weeks ago

Updating ticket from information from Asana and Kevin

User friendly description:  Some known issues about image styles include: Image cropping is not consistent in identifying focal points of the image and will not render the image correctly.  Image style size small is not set to the appropriate pixel size.  Image style size small does not align center or align right when paired with a caption. However, align left is working.  Image style center is not aligning when applied. Improvements are currently being worked on. 

Technical description: Image cropping isn’t consistently focal point and will not render the image correctly Image style size small is not set at the appropriate pixel size.  Image style size small doesn’t align correctly when has a caption and is set to center or right. Left appears ok. Image style center is not aligning when applied. 

jnicholCU commented 2 weeks ago

Images don't center align and images with captions that are aligned left or right are smaller than the image caption:

image

jnicholCU commented 2 weeks ago

We need to double check that everything from this ticket has been solved properly: https://github.com/CuBoulder/tiamat-custom-entities/issues/154