search

CuBoulder / tiamat-theme

University of Colorado Boulder Drupal 9+ base theme
GNU General Public License v2.0
3 stars 0 forks source link

Add a module-level variable override for the version string #1461

Open tirazel opened 1 day ago

tirazel commented 1 day ago

We currently have a version string we store in a variable, which is supposed to indicate which version of the codebase is in use on a site. However, this is currently just a string set separately as part of the update process, so if a codebase update failed, but the version string update succeeded, the string then incorrectly states that the codebase has been updated.

Ideally, the version string is done as a variable override in the theme module, so the correct value is returned based on the actual codebase. Currently, the config variable being manually set is 'web_express_version' in the boulder_base.settings config object.

The documentation for adding variable overrides lives here: https://www.drupal.org/docs/drupal-apis/configuration-api/configuration-override-system

timurtripp commented 1 day ago

IIRC this is initially how I wanted to do it, with the GitHub action modifying the version string in the actual codebase. @jcsparks do you remember why we decided against it?