search

CuBoulder / tiamat-theme

University of Colorado Boulder Drupal 9+ base theme
GNU General Public License v2.0
3 stars 0 forks source link

Bug in content sequence block template #418

Closed tirazel closed 1 year ago

tirazel commented 1 year ago

There seem to be twig syntax errors on lines 44, 89, and 182 in block--content-sequence.html.twig. If I remove the 'if key|first != '#'' section at the end. My twig is rusty, so I'm not sure what the intended functionality is.

timurtripp commented 1 year ago

Context: From what I can gather, this kind of if statement syntax was removed from Twig and breaking in D10. It was likely brought over from some of our earlier work meaning this problem could impact other blocks. I deemed it unnecessary and didn't put it in the Advanced Content Sequence.

timurtripp commented 1 year ago

I don't know why they removed this syntax from Twig. It works fine in other templating languages like Nunjucks and is cleaner than having a nested if block. Why can't we have nice things 🤦🏻‍♂️