search

CuBoulder / ucb_bootstrap_layouts

Layout builder templates that change column styles to bootstrap classes
GNU General Public License v2.0
0 stars 0 forks source link

Light overlay update #33

Closed patrickbrown-io closed 6 months ago

patrickbrown-io commented 6 months ago

Modifies the Light Overlay on section background images to be more white than gray so particularly light background images are no longer darkened by the overlay due

Resolves #32

timurtripp commented 6 months ago

@jnicholCU Before I merge this, is there any way around the resave issue? Any reason this isn't done using CSS classes or variables?

jnicholCU commented 6 months ago

@jnicholCU Before I merge this, is there any way around the resave issue? Any reason this isn't done using CSS classes or variables?

@timurtripp originally there wasn't a better way of doing it for that particular option. I had worked with another custom layout builder dev on this problem because we ran into the same issue with background images with color overlays. That being said I'm looking at new documentation and there might be a more clean way.

For now I think this is fine to merge and we can open up a ticket for a refactor that I can link the documentation to. The migration stuff that Michael and Jeremy have worked on are using the current method so if we change it that will need to be redone. Probably be worth talking about on Friday or Tuesday.

timurtripp commented 6 months ago

Alright. Next time you should use CSS variables, I believe it could be done that way here even if inline styles are required due to the background image. CSS variables are allowed in inline styles and it would've prevented this problem from occurring.

timurtripp commented 6 months ago

I'd go so far as to say almost anything color-related should be defined a variable and never as a hard-coded value, we reuse the same colors a lot across the site.

timurtripp commented 6 months ago

You see done like this all over the web now. Not using CSS variables will date you.