CuBoulder / ucb_ckeditor_plugins

This Drupal 9+ module contains a collection of CKEditor 5 plugins to add functionality to the WYSIWYG editor.
GNU General Public License v2.0
1 stars 0 forks source link

Button UI improvements #22

Closed timurtripp closed 1 year ago

timurtripp commented 1 year ago
patrickbrown-io commented 1 year ago

Definitely agree with 1 and 2.

I'm not sold on the idea of adding an edit contents button - when a user is creating a new button, the Edit Contents button wouldn't focus since the created button doesn't exist yet and there's no inner text field to focus to.

After save it automatically moves the focus to the inner text field, or just one click on the text to edit contents from the editor if the button already exists. With a button just for this in the UI, it would add an extra user step to click to access the UI and then click Contents button, just to focus the inner text which can already be done faster using the other routes.

Thoughts @jcsparks ?

timurtripp commented 1 year ago

The "Edit contents" would be missing or disabled when creating a new one. My only concern is there's no visual indication that clicking on the contents does anything different from clicking on the outer padding.

timurtripp commented 1 year ago

This is a non-issue if we expect folks to read the documentation – not unreasonable!