search

CuBoulder / ucb_ckeditor_plugins

This Drupal 9+ module contains a collection of CKEditor 5 plugins to add functionality to the WYSIWYG editor.
GNU General Public License v2.0
1 stars 0 forks source link

Adds Button Group Plugin #28

Closed patrickbrown-io closed 9 months ago

patrickbrown-io commented 9 months ago

Adds Button Group, allowing buttons to be selected in the editor and then wrapped in a button group element, which will present them in a horizontal navigation bar style with uniform sizes and colors.

Also changes icon for Button to be more similar to Button Group.

Resolves https://github.com/CuBoulder/tiamat-theme/issues/251

timurtripp commented 9 months ago

I'm not seeing any easy way to add a second button here. Am I missing something?

Screen Shot 2023-09-14 at 8 56 19 AM
patrickbrown-io commented 9 months ago

I'm not seeing any easy way to add a second button here. Am I missing something? Screen Shot 2023-09-14 at 8 56 19 AM

Unfortunately not yet-- talked with @jcsparks about it yesterday and got the go ahead for this to be verison one for the sandbox rebuild today, since the d7 version was just a shortcode that wrapped already made buttons. So you just need to make your buttons first and then wrap with BG when you're done for now.

The drag and drop new buttons into the existing BG is still intended to be the ideal future improvement but I wasn't able to get it working in time. Or maybe some sort of add button button on the BG UI as a backup plan?

timurtripp commented 9 months ago

I'm not seeing any easy way to add a second button here. Am I missing something? Screen Shot 2023-09-14 at 8 56 19 AM

Unfortunately not yet-- talked with @jcsparks about it yesterday and got the go ahead for this to be verison one for the sandbox rebuild today, since the d7 version was just a shortcode that wrapped already made buttons. So you just need to make your buttons first and then wrap with BG when you're done for now.

The drag and drop new buttons into the existing BG is still intended to be the ideal future improvement but I wasn't able to get it working in time. Or maybe some sort of add button button on the BG UI as a backup plan?

I'm not seeing any easy way to add a second button here. Am I missing something? Screen Shot 2023-09-14 at 8 56 19 AM

Unfortunately not yet-- talked with @jcsparks about it yesterday and got the go ahead for this to be verison one for the sandbox rebuild today, since the d7 version was just a shortcode that wrapped already made buttons. So you just need to make your buttons first and then wrap with BG when you're done for now.

The drag and drop new buttons into the existing BG is still intended to be the ideal future improvement but I wasn't able to get it working in time. Or maybe some sort of add button button on the BG UI as a backup plan?

I think the "Add" button is a fine way to solve this problem. Tagging #29.