search

Cuadrix / puppeteer-page-proxy

Additional module to use with 'puppeteer' for setting proxies per page basis.
423 stars 99 forks source link

Update cookies.js for use in latest versions of pptr #78 #79

Closed smashah closed 1 year ago

smashah commented 2 years ago

Relating to #78

guy-bartkus commented 2 years ago

Merge?

ThinhVu commented 2 years ago

Merge?

You don't need to wait for the merge to use the patch. Add the line below to package.json:

"puppeteer-page-proxy": "git+ssh://git@github.com:smashah/puppeteer-page-proxy#patch-1"

smashah commented 2 years ago

thanks @ThinhVu I have merged the patch to the main branch on my fork's repo so you can also do this now:

"puppeteer-page-proxy": "smashah/puppeteer-page-proxy"

Just F.Y.I, feel free to make a PR on smashah/puppeteer-page-proxy I will try to review quickly and merge if relevant.

TimRChen commented 2 years ago

wish this PR counld merge early.

ThinhVu commented 2 years ago

thanks @ThinhVu I have merged the patch to the main branch on my fork's repo so you can also do this now:

"puppeteer-page-proxy": "smashah/puppeteer-page-proxy"

Just F.Y.I, feel free to make a PR on smashah/puppeteer-page-proxy I will try to review quickly and merge if relevant.

Oh. I don't even know that we can use that short form. Nice.