Closed vincentlepot closed 9 years ago
@gabrielsomoza scrutinizer failed because of the travis config look at the configuration of doctrine/migrations to avoid sending empty clover report.
Thanks for your contribution @vincentlepot, its a great idea. Any chance you could also update the README.md file to document these changes?
@mikeSimonson the Scrutinizer issue should be fixed now in master, thanks for the info.
@gabrielsomoza You're right, I'll take care of the README.md :)
README updated ;)
Awesome, thanks so much for your contribution! Merging now.
You're welcome. Can you ping me when you tag the release?
Done :+1:
Thanks a lot (just one thing: you missed the 'v' at the beginning if you want to keep consistent, but it works ;))
That was actually on purpose: starting with that release I'm going to start tagging them without the 'v'. Just because it makes tags easier to read I think (the v is not needed). I'll keep it release titles though. Reason: it seems to be the way other big libraries do it :)
You have a great eye for detail btw, love it.
Instead of having only one default value possible in the template (eg
{{Question|default}}
), this PR add the ability to chain multiple default values.This can be useful to use env variables as a first default if available and, if not, fall back to a string. eg:
If MY_PARAM_ENV variable is set, use it as default, else use "default" hardcoded string.
In a deployment process, as a non-interactive execution, you can have you secrets set as env variables (and fall back to default values if not set).