search

CubeCoders / AMP

Issue tracking and documentation for AMP
https://cubecoders.com/AMP
207 stars 38 forks source link

Add Modrinth and Cursforge support #686

Open Eatham532 opened 2 years ago

Eatham532 commented 2 years ago

Feature Request

Feature Information:

There is spigot support why not Modrinth and Curseforge support for the Modded servers?

I talked to someone on Discord about this. The conversation was never really finnished. They said that it was not possible when I myself have done it in my own personal coding.

Modrinth (You don't need a key) Documentation is here

Curseforge There is information about applying for a key here

Documentation is here

I confirm:

IceOfWraith commented 2 years ago

I'm not familiar with the first one, but the second is more of an issue with their terns. They are very one-sided and provide no guarantees that if all the coding is put in to support it, that it will remain an option. Not to mention the compensation aspect they mention. They can demand payment at any time for using their API.

Eatham532 commented 2 years ago

Yeh, Modrinth is pretty new so I wouldn't expect many people to know about it. More minecraft modders are moving to using modrinth because its better than curseforge.

For the Curseforge Api their terms do not say anything about them being able to demand payment. The following taken from their terms and is the only place where the word pay is used.

Upon the External App exceeding a certain quota, to be decided and updated from time to time upon Overwolf’s sole discretion, continued use of the Platform API and/or SDK may (at Overwolf’s sole discretion) require Developer to enter into a written licensing agreement with Overwolf, which license agreement may contain payment requirements or other terms and conditions applicable to the continued use of the API or SDK. Overwolf may decline to provide access to any data or services provided through the API or SDK to the extent the External App exceeds such quota determined by Overwolf and the parties do not come to a mutual written agreement regarding an alternative arrangement.

Curseforge made it so that mods can opt out to be downloaded by third party platforms so that way they can get paid without you having to spend a dollar.

For minecraft you could use Ferium. Ferium is written in Rust and really fast. If you use it then you wont need an api key at all. The downside to this is that it only works for minecraft.

If you want to use curseforge to download mods for other games as well than you need to use the curseforge api.

IceOfWraith commented 2 years ago

Im confused by your response. That clearly states they might require payment in a written agreement.

Eatham532 commented 2 years ago

"May contain payment requirements" In the form you can say how you will pay for it and you can just say you wont. I did that myself

IceOfWraith commented 2 years ago

Correct, but they can change that at any time. The point is that having that clause means they might decide to charge CubeCoders at any time and if they refuse then the code time was wasted.

IceOfWraith commented 2 years ago

To be clear, I'm not disagreeing just to argue. This has been discussed before. In the end all that matters is what Mike decides to do.

Eatham532 commented 2 years ago

Well I could help.

I surely don't think curseforge would do that though because if they did many people would get upset. Also I know other minecraft launchers that use the Curseforge Api. I do understand your worries. Do you think Mike would see this issue?

Whaleguy5533 commented 2 years ago

the curseforge api only allows you to download mods if the author of that mod allowed it, because of the api change (i'm pretty sure)

IceOfWraith commented 2 years ago

That may be, but it doesn't change what they have in their terms unfortunately.

I would like to reach out to them and get some details on what they'd expect from CC. It would help Mike gauge if he'd be interested in working with them at least.

IceOfWraith commented 2 years ago

https://github.com/CubeCoders/AMP/issues/706

MoiraPrime commented 1 year ago

+1 to the request to add Modrinth support. They have a documentation of their API here: https://docs.modrinth.com/api-spec/ And they're becoming the most popular mod/resource pack/plugin website.

stricq commented 1 year ago

Please add Modrinth supporth. They are the defacto standard for Fabric mods and they also have Plugins as well. I am being begged by my users to add Fabric servers with lots of mods but I refuse to do so because of the maintenance time required due to no Modrinth support in AMP.

Graftax commented 7 months ago

If you add Modrinth support, I'll buy another license. I'm willing to provide proof.

stricq commented 7 months ago

I stopped using AMP after playing around with it because of a lack of Modrinth support. There is no support for Fabric or Forge (and variants) servers.

IceOfWraith commented 7 months ago

Modrinth support is planned soon. We're working through some bugs (unrelated), but I plan to tackle it in the near future.

nickheyer commented 6 months ago

I recently paid for a $40 amp license due to the implied ease of use when provisioning modded minecraft servers, via curseforge/modrinth. So far i've been entirely disappointed every step of the way.

Support for containerization: Clearly an afterthought, very unstable. Support for traefik: Definitely broken. Support for Curseforge/modrinth API's: Non-existent, even though they are used by almost every modpack manager in existence. Support in general (for a $40 license to be clear): Passive aggressive, selectively observant of complaints, mostly volunteer based from the looks of it. Just look at your GH issue template, this is a joke.

UI: Slow and buggy.

IceOfWraith commented 6 months ago

This post isn't the proper place to address these issues. If you'd like to make a post on the forums or Discord, they can be discussed further. Details of how the different aspects didn't work for you would be helpful so they can be addressed.

clovisd commented 3 months ago

+1 for Modrinth support!

Their platform and system is pretty well built, maintained, and curated and more plugins are moving there as well (not just Mods). Would be a big step up for AMP while also providing an arguably better experience. They also have pretty well documented developer support and tools that make things easier for end-users and plugin creators (hence increased adoption).

IceOfWraith commented 2 months ago

It was announced in Discord that AMP got the green light to implement CurseForge. It isn't a priority this minute, but will be coming eventually.

Whaleguy5533 commented 2 months ago

Does that include modrinth? In the last couple years modrinth has grown to become a lot more user friendly than curseforge and some modders exclusively use it, so i think it would be a great addition. It would be a big shame if you only added curseforge support.

Eatham532 commented 2 months ago

When this is added, will the current plugin implementation be improved as well? Currently the whole interface and the way it works has a lot of issues.

Also, Is there a way that I or anyone else can work on this to help with the development?

SanderVeeken commented 1 month ago

+1 for Modrinth support. I would love this feature, it would take soooo much manual setup and updating out of the equation. I understand it's a fairly big project but considering AMP is big on Minecraft, the current implementation with broken Spigot plugin support is very basic.