CubeCoders / AMP

Issue tracking and documentation for AMP
https://cubecoders.com/AMP
MIT License
207 stars 38 forks source link

Permissions unable to be viewed/set in the controller for a new instance on target #764

Open southnode opened 2 years ago

southnode commented 2 years ago

Bug Report

System Information

I confirm:

Symptoms

Reproduction

Provision a new instance from a controller to a target Go to assign permissions for a user to that instance - notice it doesn't exist Restart controller It now exists.

southnode commented 2 years ago

Note that in addition to this, if provisioned via WHMCS, the user that is created for the client does not get permissions to the instance either, so they don't exist.

PhonicUK commented 1 year ago

This has been addressed in CI, when the instance list changes the permissions node cache is now invalidated (it was doing this already, but not for template deployments) and the frontend is notified of the change, which prompts it to re-query the list of available permissions (including as a result, new/removed instances regardless of which target they're on) - this also prompts the frontend to re-query the list of users so that users that were created as a result of a template deployment are now available in the UI without even having to refresh the page never mind restarting the controller itself.

TopicsLP commented 1 year ago

Sorry to reopen this. I do still experience this issue. I thought this should be fixed with 2.4.1.2

https://discourse.cubecoders.com/t/amp-halimede-2-4-1-release-notes/2743

Permissions node cache is properly invalidated when instances are created/destroyed so it’s not necessary to restart/refresh ADS to assign permissions to newly created instances.

southnode commented 1 year ago

To clarify, based on the previous response from dev:

The issue isn't that the user themselves do not appear, however it is the instance itself that does not appear in permissions lists, such as giving a user permission to Start, Stop, Update and Manage an instance - when on the controller looking at the dropdown of the target within the "All Instances" dropdown menu, the new instance does not appear until ADS is restarted.

Re-opening issue.

BroOtti commented 1 year ago

The issue persists with v2.4.2

To clarify more, I guess we are talking about creating a new instance on a target and if we want to give a user permission to that instance it doesn't appear in the list like shown in the screenshot until a restart of the controller ADS.

image

PhonicUK commented 1 year ago

Does the new permission node appear within the target? I think this is just a propagation issue.

BroOtti commented 1 year ago

Indeed, the new permission node appears within the target

southnode commented 1 year ago

This is still an issue 8 months later. This needs to be resolved.

IceOfWraith commented 4 months ago

There were changes put in recently that should have improved this, but seems there's still cases people are experiencing it. Is it consistent or do you see any kind of pattern with it?