search

CubeCoders / AMPTemplates

For the AMP community to share Generic Module templates.
MIT License
93 stars 287 forks source link

Update enshrouded.kvp #1141

Closed Dalarialus closed 3 days ago

Dalarialus commented 3 days ago

Fix player names being correctly recorded in analytics by updating RegEx.

This is my first time modifying a RegEx, so I'd appreciate it if someone more knowledgeable can check my work.

Greelan commented 3 days ago

Can you provide relevant logs from AMP_Logs?

Dalarialus commented 3 days ago

Indeed! PasteBin

Dalarialus commented 3 days ago

Apologies if there is an established procedure that I'm not following - This is my first time ever making a pull request :)

This pull results from a thread on Discord #priority-support

Greelan commented 3 days ago

It's just that I can't verify the regex without the underlying logs. xD

You can test and verify regex at regex101.com.

I had to make some tweaks to the capture groups for them to work.

Thanks for raising this.

Dalarialus commented 3 days ago

Thanks! :)