search

CubeStuffs / CubeTime

Simple, modern speedcubing timer with many utilities, built with SwiftUI & UIKit.
https://cubetime.app
GNU General Public License v3.0
90 stars 5 forks source link

Multiphase session crashes after moving a regular solve into it #168

Closed DaHawk27 closed 6 months ago

DaHawk27 commented 1 year ago

Describe the bug App goes to the Home Screen when selecting a multiphase session after moving a single phase time to it.

To Reproduce Steps to reproduce the behavior:

  1. Click on a best single time from a single phase session.
  2. Click on move to different session.
  3. Click a multiphase session.
  4. Now when you try to switch to that session app “crashes” and take me back to the Home Screen.

Expected behavior When I tap on the new session I expect to see the best single scramble and time in the new session.

Screenshots or screen recordings

https://github.com/CubeStuffs/CubeTime/assets/138076839/210fe610-d382-4b9c-9074-225e81233c18

Crash log if applicable

Smartphone (please complete the following information):

Additional context I moved a single phase time to a multiphase time trying to copy the scramble over to the multiphase session in order to recreate the solve with the multiphase breakdown.

pdtxie commented 1 year ago

Hey there, really sorry that this has happened - we thought we had prevented moving solves between regular sessions and multiphase sessions. Unfortunately this is not supposed to happen, and the app is probably crashing as it's trying to calculate phase times for an undefined number of phases.

We'll look into adding something that can "fix" these broken sessions, but as for now I'm afraid there is nothing we can do.

DaHawk27 commented 1 year ago

Hey it’s all good! I kind of figured that’s why the app was crashing. Is it possible for me to recover that time back onto the original session? And if so how would I go about doing that? If that’s not possible, no worries at all I screenshotted the scramble so it’s not forever lost lol.

Thank you so much for reaching out!!

On Thu, Jun 29, 2023 at 12:27 AM Tim Xie @.***> wrote:

Hey there, really sorry that this has happened - we thought we had prevented moving solves between regular sessions and multiphase sessions. Unfortunately this is not supposed to happen, and the app is probably crashing as it's trying to calculate phase times for an undefined number of phases.

We'll look into adding something that can "fix" these broken sessions, but as for now I'm afraid there is nothing we can do.

— Reply to this email directly, view it on GitHub https://github.com/CubeStuffs/CubeTime/issues/168#issuecomment-1612413162, or unsubscribe https://github.com/notifications/unsubscribe-auth/BA5OFJ6ALV7Z25Y6RWDDPCLXNT747ANCNFSM6AAAAAAZXZZFWU . You are receiving this because you authored the thread.Message ID: @.***>

pdtxie commented 6 months ago

sorry about this - we've now fixed the crashing (3840b7946e7b458d457c7f1fc313787a2a381a0a), and so you should be able to re-enter the multiphase session. we've also prevented this from happening in the future.