search

Cubed-Development / Modern-Warfare-Cubed

Welcome to the official GitHub Repository for Modern Warfare Cubed!
Apache License 2.0
92 stars 60 forks source link

Prop name consistency #291

Closed strubium closed 9 months ago

strubium commented 11 months ago

🤔 What type of PR is this? (check all applicable)

📝 Description

Renames the server prop names/ids

🧐 The Rationale

consistent with the rest of the props

🎯 Key Objectives

rename the props

⏮️ Backwards Compatibility

1.12.2

📚 Related Issues & Documents

N/a

🖼️ Screenshots/Recordings

N/a

📖 Added to documentation?

SticksDeveloper commented 11 months ago

Tell me once you are done and I'll merge.

Seems good!

Koud-Wind commented 11 months ago

Conflicts arise. It is recommended that you merge directly into the https://github.com/Cubed-Development/Modern-Warfare-Cubed/tree/Rendering-Rewrite Otherwise, it will increase Luna's workload in resolving conflicts Or wait https://github.com/Cubed-Development/Modern-Warfare-Cubed/pull/256 Merge this item after merging

strubium commented 11 months ago

Tell me once you are done and I'll merge.

Seems good!

Ready, but i agree with Koud-Wind best to merge into https://github.com/Cubed-Development/Modern-Warfare-Cubed/tree/Rendering-Rewrite

strubium commented 11 months ago

Conflicts are resolved! There are now a bunch of smaller changes as it brings rendering-rewrite to be more up to date. Don't know if this is a good or not tho.

Paneedah commented 10 months ago

@Desoroxxx Awaiting your go-ahead.