Cubed-Development / Modern-Warfare-Cubed

Welcome to the official GitHub Repository for Modern Warfare Cubed!
Apache License 2.0
92 stars 60 forks source link

Remove VSS Vintorez flash #308

Closed MCT32 closed 9 months ago

MCT32 commented 10 months ago

🤔 What type of PR is this? (check all applicable)

📝 Description

Removes the muzzle flash from the VSS Vintorez since according to wikipedia, the built in suppressor reduces the flash, and in videos of the gun being used online the flash is not visible.

🧐 The Rationale

This change simply make the gun behave more realistically.

🎯 Key Objectives

Removing the muzzle flash on the VSS Vintorez

🚦 Testing

Shoot the rifle and observe the flash is gone.

⏮️ Backwards Compatibility

Should be

📚 Related Issues & Documents

Fixes #284

🖼️ Screenshots/Recordings

https://github.com/Cubed-Development/Modern-Warfare-Cubed/assets/32090502/13e4796b-0fc1-4528-9657-91eb5d74b45e

📖 Added to documentation?

😄 [optional] What gif best describes this PR or how it makes you feel?

img

Desoroxxx commented 10 months ago

Missing changelog entry

MCT32 commented 10 months ago

Added the change to the changelog now. I've added it to the removed section but if it should be in another section like "changed" or "fixed" let me know and I'll move it

Braiam23 commented 9 months ago

Thank you very much for the contribution to the mod, but I will move your changes that you made to another Pull request to avoid future conflicts