Closed Paneedah closed 8 months ago
The recent update to the weapon crafting library involves refining the crafting process within the GUI container station, particularly in the item requirement check during crafting selection. Additionally, the network packet handling for the crafting station has been enhanced with a new import and improved logic for verifying and managing items in crafting recipes. Sound-related functionality has also been added to the GUI button custom class, and the control flow in the GUI container ammo press and workbench has been modified to accommodate selected crafting pieces and crafting modes.
File Path | Change Summary |
---|---|
.../crafting/base/GUIContainerStation.java |
Modified item requirement check logic in onSelectNewCrafting method; updated craftButton state. |
.../crafting/ammopress/GUIContainerAmmoPress.java |
Modified logic in updateScreen method based on selected crafting piece. |
.../crafting/workbench/GUIButtonCustom.java |
Added sound-related functionality; imported sound classes; overridden playPressSound method. |
.../crafting/workbench/GUIContainerWorkbench.java |
Updated control flow for setting crafting mode and selected crafting piece; filled filtered list. |
.../network/packets/StationPacket.java |
Added org.lwjgl.Sys import; refactored item verification and removal logic for crafting recipes. |
.../network/packets/StationClientPacket.java |
Modified logic for handling client packet in WorkshopClientPacketHandler . |
Changelog.md |
Fixes to GUI updates, button sound behavior, and craft button state based on crafting recipe. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Warning: OreDict support was removed in this PR. Awaiting for @SticksDeveloper to re-implement.
Warning: OreDict support was removed in this PR. Awaiting for @SticksDeveloper to re-implement.
OreDict is not removed in this PR, and it was never supported, a fix for OreDict related crash is removed in this pr this will be fixed shortly
It is good for Merge!
Wrong button
📝 Description
This should now finally properly track items within the workbench and remove them without any weird issues (such as not being able to craft anything).
🚦 Testing
Generic testing done locally in staffchat, boring. This does however need to be messed with and tested further.
📖 Added to documentation?
Summary by CodeRabbit