Cubed-Development / Modern-Warfare-Cubed

Welcome to the official GitHub Repository for Modern Warfare Cubed!
Apache License 2.0
92 stars 59 forks source link

Workbench Hotfixes #332

Closed Paneedah closed 8 months ago

Paneedah commented 8 months ago

📝 Description

This should now finally properly track items within the workbench and remove them without any weird issues (such as not being able to craft anything).

🚦 Testing

Generic testing done locally in staffchat, boring. This does however need to be messed with and tested further.

📖 Added to documentation?

Summary by CodeRabbit

coderabbitai[bot] commented 8 months ago

Walkthrough

The recent update to the weapon crafting library involves refining the crafting process within the GUI container station, particularly in the item requirement check during crafting selection. Additionally, the network packet handling for the crafting station has been enhanced with a new import and improved logic for verifying and managing items in crafting recipes. Sound-related functionality has also been added to the GUI button custom class, and the control flow in the GUI container ammo press and workbench has been modified to accommodate selected crafting pieces and crafting modes.

Changes

File Path Change Summary
.../crafting/base/GUIContainerStation.java Modified item requirement check logic in onSelectNewCrafting method; updated craftButton state.
.../crafting/ammopress/GUIContainerAmmoPress.java Modified logic in updateScreen method based on selected crafting piece.
.../crafting/workbench/GUIButtonCustom.java Added sound-related functionality; imported sound classes; overridden playPressSound method.
.../crafting/workbench/GUIContainerWorkbench.java Updated control flow for setting crafting mode and selected crafting piece; filled filtered list.
.../network/packets/StationPacket.java Added org.lwjgl.Sys import; refactored item verification and removal logic for crafting recipes.
.../network/packets/StationClientPacket.java Modified logic for handling client packet in WorkshopClientPacketHandler.
Changelog.md Fixes to GUI updates, button sound behavior, and craft button state based on crafting recipe.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - You can directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging `@coderabbitai` in a comment. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - You can tag `@coderabbitai` in a PR comment and ask questions about the PR and the codebase. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.` - `@coderabbitai read the files in the src/scheduler package and generate README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
Paneedah commented 8 months ago

Warning: OreDict support was removed in this PR. Awaiting for @SticksDeveloper to re-implement.

Desoroxxx commented 8 months ago

Warning: OreDict support was removed in this PR. Awaiting for @SticksDeveloper to re-implement.

OreDict is not removed in this PR, and it was never supported, a fix for OreDict related crash is removed in this pr this will be fixed shortly

SticksDeveloper commented 8 months ago

It is good for Merge!

SticksDeveloper commented 8 months ago

Wrong button