Cubed-Development / Modern-Warfare-Cubed

Welcome to the official GitHub Repository for Modern Warfare Cubed!
Apache License 2.0
92 stars 59 forks source link

Fix VSS Vintorez having a flash #340

Closed strubium closed 8 months ago

strubium commented 8 months ago

📝 Description

Adds the changes by MCT32 in PR #308. Everything is copy-pasted form there PR

🎯 Goals

This change simply makes the gun behave more realistically.

❌ Non Goals

Fix eveything

🚦 Testing

https://private-user-images.githubusercontent.com/32090502/284242502-13e4796b-0fc1-4528-9657-91eb5d74b45e.mp4?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDQ0OTU4MjQsIm5iZiI6MTcwNDQ5NTUyNCwicGF0aCI6Ii8zMjA5MDUwMi8yODQyNDI1MDItMTNlNDc5NmItMGZjMS00NTI4LTk2NTctOTFlYjVkNzRiNDVlLm1wND9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTA1VDIyNTg0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZiMjFjOGQwNjUwOWFjMTA2YjhiMzA1ZGRhOWZlOWMzNWRiNmNhNzFjOWM2YzViN2RjNDYxOThlNDFmN2FkYmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.TttuWhpe-WYhJAzrlf-lzLy8zDdFC4SjM7GH4DWCYbA

⏮️ Backwards Compatibility

1.12.2

📚 Related Issues & Documents

Fixes https://github.com/Cubed-Development/Modern-Warfare-Cubed/issues/284

📖 Added to documentation?

Summary by CodeRabbit

coderabbitai[bot] commented 8 months ago

Walkthrough

The recent update addressed several bugs and made optimizations across the game. Notably, it fixed the custom skin system, rendering issues, and user interface problems. The muzzle flash from the VSS Vintorez, which was not supposed to occur, has been removed. Additionally, several under-the-hood improvements were made to enhance the game's performance.

Changes

File Path Change Summary
Changelog.md Updated with fixes for custom skin system, rendering errors, missing language entries, animation and tooltip issues, inventory positioning, exposure correction, weapon use in spectator mode, and spawning math corrections. Also noted the removal of muzzle flash from VSS Vintorez and general optimizations.
.../mwc/items/guns/VSSVintorezFactory.java Removed unused code and set withFlashIntensity to 0.0f to eliminate muzzle flash.

Assessment against linked issues

Objective Addressed Explanation
Muzzle flash when shooting from VSS Vintorez (#284) The withFlashIntensity value has been set to 0.0f, which directly addresses the issue of muzzle flash when firing the VSS Vintorez.

The code changes are specifically targeted towards the objectives listed in the linked issue, and upon reviewing the provided code snippets, it is clear that the issue of muzzle flash on the VSS Vintorez has been addressed by setting the flash intensity to zero, hence meeting the primary objective.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit's AI: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.` - `@coderabbitai read the files in the src/scheduler package and generate README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
Koud-Wind commented 8 months ago

It is already included in https://github.com/Cubed-Development/Modern-Warfare-Cubed/pull/312