Closed Paneedah closed 2 months ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The recent update focuses on removing the proning feature across the board, affecting both gameplay mechanics and codebase structure. Changes include the elimination of methods and logic related to player proning in various classes, simplification of code by removing conditional checks for proning, and refactoring of some unrelated methods for better readability and efficiency. Additionally, there's a shift in event handling and key input management, further streamlining the game's functionality and code maintenance.
Files | Summary |
---|---|
Changelog.md , .../asm/Interceptors.java , .../utils/MWCUtil.java , .../utils/PlayerUtil.java , .../CommonEventHandler.java , WeaponKeyInputHandler.java |
Removed proning feature and related logic, including checks for player proning and handling of proning-specific key inputs. |
.../MWC.java |
Streamlined imports, removed obsolete message handler registrations. |
.../weaponlib/EntityShellCasing.java |
Refactored shell casing positioning logic for better code readability and maintainability. |
.../weaponlib/PlayerRenderer.java |
Refactored rendering logic, including adjustments to constructor parameters and simplification of method logic. |
[!TIP]
Early access features
- OpenAI `gpt-4o` model for reviews and chat. Note: - You can disable early access features from the CodeRabbit UI or by setting `early_access: false` in the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are always opted into early access features.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
When a player is proning, mod will write an NBT with the content player_entity_flags
to the player. Personally, I think it is necessary to delete CompatibleExtraEntityFlags
, EntityControlServerMessageHandler
and EntityControlClientMessageHandler
When a player is proning, mod will write an NBT with the content
player_entity_flags
to the player. Personally, I think it is necessary to deleteCompatibleExtraEntityFlags
,EntityControlServerMessageHandler
andEntityControlClientMessageHandler
Definitely overlooked those. Thanks for the heads up.
๐ Description
This PR aims to remove everything relevant to the player proning feature.
๐ฏ Goals
Remove the ability for players to prone and remove all trace of proning ever existing. Okay maybe not completely, but for the most part.
๐ฆ Testing
Tested this by running within dev-env and running around, trying to force myself to prone (external cheat plugin I made before) and done all sorts of actions to make sure no random null pointers exist.
Could not produce any issues other than commit 6a6203b.
โฎ๏ธ Backwards Compatibility
Fully backwards compatible upon updating. Players will just be unable to lay down.
๐ Added to documentation?
Summary by CodeRabbit