Closed Desoroxxx closed 7 months ago
The update introduces a mechanism to efficiently manage the state of the weather renderer within a rendering pipeline. By adding a boolean flag to monitor changes in the original weather renderer's state, the system now ensures that updates to the originalWeatherRenderer
occur only when necessary. This optimization reduces unnecessary processing, improving the efficiency of the rendering process by updating components based on actual changes or discrepancies between current and designated renderer instances.
File | Change Summary |
---|---|
.../weaponlib/render/bgl/PostProcessPipeline.java |
Added isOriginalWeatherRendererDirty flag to track changes in the original weather renderer state. Updated setWorldElements logic to conditionally refresh originalWeatherRenderer . |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Phew we can finally release this highly important fix
๐ Description
Fixed a literally unplayable issue that would cause the original weather renderer to be overwritten, making you go throught the unberable pain of restarting your game after changing a config.
๐ฏ Goals
โ Non Goals
๐ฆ Testing
Tested disabling and enabling the fancy weather while in a world
โฎ๏ธ Backwards Compatibility
Only logic related not data related backward compatibility is untouched
๐ Related Issues & Documents
Everything below: https://discord.com/channels/801852948854079489/1128548815994101821/1204143093214085140
๐ผ๏ธ Screenshots/Recordings
Not a visual change
๐ Added to documentation?
Summary by CodeRabbit