Updates to bullet display HUD

[Paneedah]

📝 Description

This PR is all about the Ammo HUD and the bottom-right ammo counter display, improvements and small bug fixes.

🎯 Goals

• Create a universal drawAmmoCounter method that works with both guns and magazines
• Make magazines draw their ammo counter like guns, not a white text in the top-right corner
• Only display the [B] (change firing mode) if there's multiple modes to choose from
• Show the crosshair when holding a magazine (idfk why it doesn't alr do that)

❌ Non Goals

It is not a goal to update old methods and try to do stupid shit to them to get them to work.

It is not a goal to update anything that isn't simply visual / in the HUD.

🚦 Testing

This has been tested within and outside of dev-env. Tested all HUD related items such as open door, combinations of magazines and guns, and more.

⏮️ Backwards Compatibility

Perfectly backwards compatible and won't break anything. Old method has been marked as @Deprecated and should be removed in the near future.

📚 Related Issues & Documents

N/A

🖼️ Screenshots/Recordings

Original Display:

New:

📖 Added to documentation?

• [ ] 📜 README.md
• [ ] 📑 Documentation
• [ ] 📓 Javadoc
• [ ] 🍕 Comments
• [x] 🙅 No documentation needed

Summary by CodeRabbit

• New Features
  • Contextual prompts for changing fire modes are now visible only when applicable.
  • Magazines now display bullet counts, aligning with the display on guns.
  • Crosshair visibility is enhanced when holding a magazine.
• Refactor
  • Improved clarity and functionality in the game's user interface handling.

[coderabbitai[bot]]

Walkthrough

The latest update to Modern Warfare Cubed Version 0.2 introduces a refined user experience with improvements focused on in-game interactions and visual cues. Notably, the update enhances the way players switch fire modes, view ammo counts directly on magazines as well as on guns, and interact with the game's crosshairs. These changes aim to provide a more intuitive and immersive gameplay experience by ensuring that crucial information and options are presented more contextually and visually appealing.

Changes

File Path	Change Summary
Changelog.md	- Contextual fire mode prompts - Magazine bullet count display - Crosshair visibility with magazine
.../weaponlib/CustomGui.java	- Added Item import - Replaced RenderGameOverlayEvent.ElementType.HELMET with HELMET - Removed handleModificationHUD - Deprecated handleAmmoCounter for drawAmmoCounter - Refactored onRenderCrosshair - Introduced and enhanced drawAmmoCounter for ammo display logic

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

---

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.