search

Cubed-Development / Modern-Warfare-Cubed

Welcome to the official GitHub Repository for Modern Warfare Cubed!
Apache License 2.0
91 stars 59 forks source link

Hotfix for #392 #403

Closed Paneedah closed 5 months ago

Paneedah commented 5 months ago

📝 Description

Creating this PR on behalf of @Koud-Wind. The aim of this PR is to fix the issue where terrorist weapon bullet count goes to 32,000.

🎯 Goals

Fix the bug

❌ Non Goals

Code cleanup is not a goal

🚦 Testing

Koud says he tested it. I am not currently home - please double check or make a quick video @Koud-Wind.

⏮️ Backwards Compatibility

Perfectly fine.

📚 Related Issues & Documents

📖 Added to documentation?

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago

Walkthrough

Version 0.1.4 of Modern Warfare Cubed introduces significant changes to weapon behavior, where weapons no longer prevent unloading with a full inventory but drop their magazines on the ground instead. Various fixes have been implemented to address issues with fog in optical scopes, reloading, and inventory management related to weapons, magazines, and attachments.

Changes

File Path Change Summary
.../weaponlib/ai/EntityCustomMob.java Modified initAmmo method to generate and apply a consistent ammo value to weapon and item stack.
.../weaponlib/MagazineReloadAspect.java Updated evaluateUnload method to include conditional checks before adding item stacks to the player's inventory.
.../weaponlib/WeaponAttachmentAspect.java Refactored changeAttachment and removeAttachment methods to improve item addition and removal logic.
.../weaponlib/WeaponReloadAspect.java Refactored code by removing unused imports, adjusting state transitions, and simplifying alert logic.
.../resources/assets/mwc/lang/en_US.lang,
.../es_ES.lang,
.../pt_BR.lang,
.../tr_TR.lang,
.../zh_CN.lang		 Removed inventory full message strings from language files to likely update inventory full message handling.

Assessment against linked issues

Objective Addressed Explanation
The weapons dropped by bandits and soldiers will lead to a surge in bullets (#392) ✅ The changes in weapon behavior directly address this issue by dropping magazines instead of preventing unloading.
Address the issue where using the command to create a mob spawner with a soldier results in them spawning without a weapon (#333) ❌ The changes in this PR do not directly relate to mob spawner behavior or weapon spawning issues.
Investigate spawned soldiers sometimes being untargetable by players (#333) ❌ The changes made do not specifically address the behavior of spawned soldiers in relation to player targeting.

Related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
Paneedah commented 5 months ago

@Koud-Wind please add an entry to "Fixed" in the changelog.