Closed dark-steveneq closed 6 months ago
The primary change involves the removal of the @SideOnly(Side.CLIENT)
annotation from the ClientEventHandler
class. This adjustment suggests a shift in how the event handler is designated for client-side operations, potentially affecting how client-specific code is segregated or integrated within the project.
File Path | Change Summary |
---|---|
.../mwc/handlers/ClientEventHandler.java |
Removed @SideOnly(Side.CLIENT) annotation. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Not the solution, the fix is to only call it from client side
Understandable. I only made this as a temporary "fix" because it was easier. Gonna do it the proper way you mentioned.
โฆon dedicated servers
๐ Description
When starting a dedicated server with MWC 0.1.4 the server crashes once it tries to initialize MWC because the mod can't add stuff to
COOKING_QUEUE
becausesrc/main/java/com/paneedah/mwc/handlers/ClientEventHandler.java
can only run on client-side. This pull request removes that restriction which is stupid but at least it works now๐ฏ Goals
Hack the hack to make everything work as it should
โ Non Goals
๐ฆ Testing
I can start and play on a debug server so I guess everything works
โฎ๏ธ Backwards Compatibility
Everything should work I guess
๐ Related Issues & Documents
๐ผ๏ธ Screenshots/Recordings
๐ Added to documentation?
๐ [optional] What gif best describes this PR or how it makes you feel?
Summary by CodeRabbit