Closed Braiam23 closed 2 weeks ago
The changes across various files in the project primarily focus on updating the model classes for Makarov attachments and sights to extend ModelWithAttachments
instead of ModelBase
. This involves adding new ModelRenderer
fields, updating constructors, and modifying the render
and setRotationAngle
methods. Additionally, image file references for models have been standardized to "makarovpm.png" across different model and attachment classes.
File Path | Change Summary |
---|---|
.../models/MakarovMag.java |
Updated class to extend ModelWithAttachments , added new ModelRenderer fields, updated constructor, added setRotationAngle method. |
.../models/makarovfrontsight.java |
Updated class to extend ModelWithAttachments , revised field declarations, updated constructor and render method. |
.../models/makarovrearsight.java |
Updated class to extend ModelWithAttachments , added new ModelRenderer fields, updated constructor, added setRotationAngle method. |
.../weapons/Attachments.java |
Standardized image file references for Makarov models to "makarovpm.png". |
.../weapons/AuxiliaryAttachments.java |
Updated withModel method call for Makarov_Slide to use MakarovPMSlide and "makarovpm.png". |
.../weapons/Magazines.java |
Changed file path for model in withModel method from "makarovmag.png" to "makarovpm.png". |
[!TIP]
New Features and Improvements
## Review Settings Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. ## AST-based Instructions CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the [documentation](https://docs.coderabbit.ai/guides/review-instructions#ast-based). ## Community-driven AST-based Rules We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the [ast-grep-essentials](https://github.com/coderabbitai/ast-grep-essentials) repository for more information. ## New Static Analysis Tools We are continually expanding our support for static analysis tools. We have added support for `biome`, `hadolint`, and `ast-grep`. Update the settings in your `.coderabbit.yaml` file or head over to the settings page to enable or disable the tools you want to use. ## Tone Settings Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples: - Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!" - Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!" - Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!" ## Revamped Settings Page We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to `.coderabbit.yaml` will be reflected in the settings page, and vice versa. ## Miscellaneous - Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the `enable_free_tier` setting. - Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (`local`) or the organization (`global`) level using the `knowledge_base` setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations. - High-level summary placement: You can now customize the location of the high-level summary in the PR description using the `high_level_summary_placeholder` setting (default `@coderabbitai summary`). - Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the `request_changes_workflow` setting.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Will go back to this after the thing
📝 Description
In this PR it only rescues the texture improvements for some weapons, in this PR not a single FACTORY file is modified. NOTE: in this PR no factory files will be modified until the head developers give permission modifies textures like:
🎯 Goals
Texture update for FN FAL by Vic4Games (no factory modification required)
Texture update for G3 by Braiam23 (no factory modification required)
Texture update for MakarovPM and PB by Vic4Games (required modifying some files)
❌ Non Goals
🚦 Testing
For weapons like the G3 and FN FAL it is not necessary to modify models, but for the MakarovPM(PB) pistol it was necessary to modify the models so that the textures load correctly
⏮️ Backwards Compatibility
1.12.2
📚 Related Issues & Documents
nothing
🖼️ Screenshots/Recordings
📖 Added to documentation?