coderabbitai[bot]
commented
2 weeks ago Walkthrough
## Walkthrough The changes involve the removal of various static item attachments and an item magazine from the `Attachments`, `AuxiliaryAttachments`, and `Magazines` classes within the game's weapon management system. Specifically, the `StonerHANDGUARD`, `MAS21Mount`, `StonerHATCH`, `StonerBELT`, `MAS21Slide`, `MAS21Part`, `MAS21Barrel`, and `StonerMag` have all been removed. Additionally, the `MAS21` item has been eliminated from the `Guns` class, affecting weapon customization options. ## Changes | Files | Change Summary | |-----------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------| | `src/main/java/com/paneedah/mwc/weapons/Attachments.java` | Removed `StonerHANDGUARD` and `MAS21Mount` attachments and their initialization logic. | | `src/main/java/com/paneedah/mwc/weapons/AuxiliaryAttachments.java` | Removed `StonerHATCH`, `StonerBELT`, `MAS21Slide`, `MAS21Part`, and `MAS21Barrel` attachments and their initialization logic. | | `src/main/java/com/paneedah/mwc/weapons/Magazines.java` | Removed `StonerMag` item magazine and its initialization logic. | | `src/main/java/com/paneedah/mwc/weapons/Guns.java` | Removed `MAS21` item and its initialization logic. |Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
📝 Description
The MAS21 is a fictional weapon and similar to many handguns, the reason for removing this weapon is because it is fictional and generic to other pistols like the Glock, being a weapon with Weapon System 1 and not craftable, it is a very little used weapon, on the other hand this weapon uses many unnecessary assets. The StonerA1 is a fictional weapon somewhat similar to the prototypes of the real weapon called KAC LAMG, the model of this weapon in the game is an ugly model and nothing similar to the original design, the weapon has many visual problems such as textures and accessories. And two models of pistol parts not used in the mod (P220 and P225)
🎯 Goals
Clean up unnecessary files and avoid updating generic or fictitious weapons, also clean up two unnecessary models
❌ Non Goals
Not breaking the game (I doubt the game will break, the MAS21 and StonerA1 are WS1 weapons with many visual bugs) on the other hand they are weapons that cannot be crafted. If you want to convert those two weapons to WS2, they will become generic weapons
🚦 Testing
N/A
⏮️ Backwards Compatibility
It is fully compatible with previous versions, but when the player is loading his game or his world in minecraft, the parts/components of the weapons (MAS21 - StonerA1) no longer appear or do not recognize those models *Important: only a message appears that these specific components are not loaded or recognized in the mod
📚 Related Issues & Documents
N/A
🖼️ Screenshots/Recordings
N/A
📖 Added to documentation?