coderabbitai[bot]
commented
2 months ago [!CAUTION]
Review failed
The pull request is closed.
📝 Walkthrough
## Walkthrough The pull request introduces significant updates to the tooltip system in Modern Warfare Cubed Version 0.2, enhancing the information provided for weapons, attachments, and melee weapons. It includes new translations in German and Ukrainian, a new sound effect for shooting snow, and visual enhancements like overhauled textures and models for specific holographic sights. Functionality changes include adjustments to fire mode hints and magazine visibility. The `Holographic` and `Holographic2` classes have been restructured, consolidating model components and updating rendering logic. Bug fixes and performance optimizations are also included, alongside dependency updates. ## Changes | Files | Change Summary | |--------------------------------------------|-------------------------------------------------------------------------------------------------| | `Changelog.md` | Updated dependency requirements for `MixinBooter` and `Red Core`. Added significant updates to tooltips, translations, sound effects, visual enhancements, and bug fixes. | | `src/main/java/com/paneedah/mwc/models/Holographic.java` | Significant restructuring of `ModelRenderer` components, renaming, and adjustments to texture dimensions and geometry. | | `src/main/java/com/paneedah/mwc/models/Holographic2.java` | Complete overhaul of model structure, consolidating components into a single `ModelRenderer`, with simplified constructor and rendering logic. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant TooltipSystem participant Holographic participant Holographic2 User->>TooltipSystem: Request Weapon Info TooltipSystem->>User: Display Enhanced Tooltip User->>Holographic: Initialize Holographic Model Holographic->>Holographic: Set texture dimensions Holographic->>Holographic: Define cube geometry Holographic->>User: Render Model User->>Holographic2: Initialize Holographic2 Model Holographic2->>Holographic2: Set texture dimensions Holographic2->>Holographic2: Define geometry using ModelBox Holographic2->>User: Render Model ```Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Braiam23
Desoroxxx
github-actions[bot]
📝 Description
This PR contains improved textures for the holographic sights, and also improves the models I try to replicate to real-life models. What differentiates it from other PRs is that the non-visible parts of the models do not have textures, making it only focus on the visible parts.
Improves the model and texture of the holographic (Black color)
Improves the texture and eliminates the z-fighting of the model (Tan color)
🎯 Goals
Perform texture optimization tests with small models
Improve texture quality (A little closer to the original Vic Modern Warfare style)
❌ Non Goals
Breaking holographic sight textures in-game
🚦 Testing
It works correctly...
⏮️ Backwards Compatibility
Fully compatible with older versions
📚 Related Issues & Documents
N/A
🖼️ Screenshots/Recordings
📖 Added to documentation?
😄 [optional] What gif best describes this PR or how it makes you feel?
N/A
By the way, if you have no idea what to do with the mod, let the designers' work revive the mod or let me manage the project for a few days XD.
Now if you don't accept the PR I don't know how I can help you with the mod either.