search

Cubed-Development / Modern-Warfare-Cubed

Welcome to the official GitHub Repository for Modern Warfare Cubed!
Apache License 2.0
93 stars 60 forks source link

Refractor the Color System #503

Closed strubium closed 1 week ago

strubium commented 3 weeks ago

📝 Description

Refractor FlatUIColors into ColorPalette.java, also add some javadoc

🎯 Goals

Slowly remove the Jim folder, and combine files that serve the same purpose

❌ Non Goals

Color configuring, break the mod

🚦 Testing

It works!

⏮️ Backwards Compatibility

1.12.2

📚 Related Issues & Documents

N/A

🖼️ Screenshots/Recordings

2024-10-21_15 50 42

📖 Added to documentation?

coderabbitai[bot] commented 3 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough ## Walkthrough The pull request introduces significant changes to the color management system within the GUI components of the application. It removes the `FlatUIColors` class and replaces its usage with a new `ColorPalette` class that centralizes color definitions. The `CustomGui` and `ModificationGUI` classes are updated to utilize the new color constants, ensuring consistent color application across the user interface. The overall logic of the affected methods remains unchanged, focusing solely on improving color references. ## Changes | File Path | Change Summary | |-----------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `src/main/java/com/paneedah/weaponlib/CustomGui.java` | Removed import for `FlatUIColors`, added import for `ColorPalette`. Updated methods to replace `FlatUIColors` color constants with `ColorPalette` constants (`SUN_FLOWER`, `WHITE`, `BRIGHT_YARROW`, `POMEGRANATE`). | | `src/main/java/com/paneedah/weaponlib/jim/util/color/FlatUIColors.java` | Deleted the `FlatUIColors` class, which contained static color constants. | | `src/main/java/com/paneedah/weaponlib/render/gui/ColorPalette.java` | Introduced new color constants categorized into "V1 Pallet" and "American Pallet". Added Javadoc comment describing the purpose of the constants. | | `src/main/java/com/paneedah/weaponlib/render/ModificationGUI.java` | Removed `TOOLTIP_COL_NORMAL` constant and replaced its usage with `ColorPalette.BLACK`. Updated rendering logic to use colors from `ColorPalette` for various GUI elements. | ## Possibly related PRs - #503: The changes in this PR directly modify the `CustomGui` class, including the removal of `FlatUIColors` and the introduction of `ColorPalette`, which aligns perfectly with the changes made in the main PR regarding color management for HUD rendering.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Desoroxxx commented 2 weeks ago

(also no need to do a changelog for this, it falls under the general cleanup category)