search

Cubed-Development / Modern-Warfare-Cubed

Welcome to the official GitHub Repository for Modern Warfare Cubed!
Apache License 2.0
93 stars 60 forks source link

Fix the swapped images in the changelog #528

Closed strubium closed 4 hours ago

strubium commented 3 days ago

📝 Description

Fixes the swapping images in the changelog

🎯 Goals

❌ Non Goals

🖼️ Screenshots/Recordings

Before:

image

After:

image

📖 Added to documentation?

coderabbitai[bot] commented 3 days ago
📝 Walkthrough ## Walkthrough The pull request introduces significant updates to the Modern Warfare Cubed project, including a rework of tooltips for weapons and attachments, new translations, and a new sound effect. It modifies the display of fire mode hints, unifies ammunition counters, and adjusts reloading mechanics. Several items have been removed, and the codebase has been cleaned up with dependency updates and performance optimizations. The changelog reflects these changes, emphasizing improvements in user interface elements and overall functionality. ## Changes | File/Path | Change Summary | |-----------------------------------------------------|---------------------------------------------------------------------------------------------------| | `Changelog.md` | Updated to reflect changes in version 0.2, including tooltips rework, new translations, and fixes. | | `src/main/resources/lang/` | Added translations for German and Ukrainian languages. | | `src/main/resources/sounds/` | Added new sound effect for shooting snow. | | `build.gradle` | Updated dependencies to require Red Core 0.6 and MixinBooter 9.4. | | `mcmod.info` | Updated with new author list and mod description. | | Various files related to tooltips and mechanics | Overhauled tooltips for weapons, magazines, and vests; adjusted reloading mechanics; removed unused features. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant Game participant UI participant Sound User->>UI: Interacts with weapon UI->>Game: Requests tooltip info Game->>UI: Sends updated tooltip info UI->>User: Displays tooltip User->>Game: Selects fire mode Game->>UI: Shows fire mode hint (if applicable) User->>Sound: Triggers shooting action Sound->>Game: Plays shooting sound effect ```

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 3 days ago

Qodana for JVM

21603 new problems were found

Inspection name Severity Problems
Unchecked warning 🔶 Warning 10614
Unnecessary 'this' qualifier 🔶 Warning 4012
Deprecated API usage 🔶 Warning 1510
Auto-boxing 🔶 Warning 886
@NotNull/@Nullable problems 🔶 Warning 417
Statement with empty body 🔶 Warning 361
Field can be local 🔶 Warning 313
Lombok @Getter may be used 🔶 Warning 276
Nullability and data flow problems 🔶 Warning 183
Auto-unboxing 🔶 Warning 144
Unused assignment 🔶 Warning 126
Non-constant field with upper-case name 🔶 Warning 114
Constant values 🔶 Warning 108
Redundant local variable 🔶 Warning 101
Javadoc declaration problems 🔶 Warning 95
Lombok @Setter may be used 🔶 Warning 89
Questionable name 🔶 Warning 76
Possibly lossy implicit cast in compound assignment 🔶 Warning 46
Call to 'printStackTrace()' 🔶 Warning 36
Declaration has problems in Javadoc references 🔶 Warning 24
Result of method call ignored 🔶 Warning 18
Deprecated member is still used 🔶 Warning 14
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 14
Dynamic regular expression can be replaced by compiled 'Pattern' 🔶 Warning 13
Link specified as plain text 🔶 Warning 13
Method is identical to its super method 🔶 Warning 13
Suspicious collection method call 🔶 Warning 13
'Set' can be replaced with 'EnumSet' 🔶 Warning 11
Integer division in floating-point context 🔶 Warning 9
Mismatched query and update of collection 🔶 Warning 9
Unused import 🔶 Warning 9
'Map' can be replaced with 'EnumMap' 🔶 Warning 8
String concatenation as argument to 'StringBuilder.append()' call 🔶 Warning 8
Class is exposed outside of its visibility scope 🔶 Warning 7
Condition is covered by further condition 🔶 Warning 7
Octal integer 🔶 Warning 7
Suspicious variable/parameter name combination 🔶 Warning 7
Vulnerable imported dependency 🔶 Warning 7
Functional expression can be folded 🔶 Warning 6
Copy of existing static method body 🔶 Warning 6
Unnecessary unary minus 🔶 Warning 6
Unstable API Usage 🔶 Warning 6
Bulk operation can be used instead of iteration 🔶 Warning 6
Catch block may ignore exception 🔶 Warning 5
Redundant type cast 🔶 Warning 5
Variable is assigned to itself 🔶 Warning 5
Stream API call chain can be simplified 🔶 Warning 5
Dangling Javadoc comment 🔶 Warning 4
Duplicate condition 🔶 Warning 4
Inner class may be 'static' 🔶 Warning 4
Manual min/max calculation 🔶 Warning 4
AutoCloseable used without 'try'-with-resources 🔶 Warning 3
Too weak variable type leads to unnecessary cast 🔶 Warning 3
Mismatched read and write of array 🔶 Warning 3
Value passed as parameter never read 🔶 Warning 3
String concatenation in loop 🔶 Warning 3
Local variable used and declared in different 'switch' branches 🔶 Warning 3
Unnecessary 'continue' statement 🔶 Warning 3
'default' not last case in 'switch' 🔶 Warning 2
Call math rounding with 'int' argument 🔶 Warning 2
Redundant operation on empty container 🔶 Warning 2
Redundant usage of unmodifiable collection wrappers 🔶 Warning 2
Method does not call super method 🔶 Warning 2
Caught exception is immediately rethrown 🔶 Warning 1
Redundant 'Collection.addAll()' call 🔶 Warning 1
'static' method declared 'final' 🔶 Warning 1
Call to 'toString()' on array 🔶 Warning 1
Method name same as class name 🔶 Warning 1
String comparison using '==', instead of 'equals()' 🔶 Warning 1
'String.equals()' can be replaced with 'String.isEmpty()' 🔶 Warning 1
Minimum 'switch' branches 🔶 Warning 1
Unary plus 🔶 Warning 1
Commented out code ◽️ Notice 1004
Duplicated code fragment ◽️ Notice 676
Non-distinguishable logging calls ◽️ Notice 33
Non-constant string concatenation as argument to logging call ◽️ Notice 17
'if' statement with identical branches or common parts ◽️ Notice 15
Constant values ◽️ Notice 14
Method can be extracted ◽️ Notice 12
Multiple occurrences of the same expression ◽️ Notice 4
Duplicate branches in 'switch' ◽️ Notice 3
Non-strict inequality '>=' or '<=' can be replaced with '==' ◽️ Notice 1

☁️ View the detailed Qodana report

Detected 18 dependencies # Third-party software list This page lists the third-party software dependencies used in Modern Warfare Cubed | Dependency | Version | Licenses | |-------------------------------------------------------------------------|---------------|--------------------------------------------------------------------------------------------------------------------------------------------| | [commons-codec](http://commons.apache.org/proper/commons-codec/) | 1.10 | [Apache-2.0](http://www.apache.org/licenses/) | | [commons-compress](http://commons.apache.org/proper/commons-compress/) | 1.8.1 | [Apache-2.0](http://www.apache.org/licenses/) | | [commons-io](http://commons.apache.org/proper/commons-io/) | 2.5 | [Apache-2.0](http://www.apache.org/licenses/) | | [commons-lang3](http://commons.apache.org/proper/commons-lang/) | 3.5 | [Apache-2.0](http://www.apache.org/licenses/) | | [commons-logging](http://commons.apache.org/proper/commons-logging/) | 1.1.3 | [Apache-2.0](http://www.apache.org/licenses/) | | groovyscript | 1.2.0-hotfix1 | [MIT](http://opensource.org/licenses/mit-license.php) | | [httpclient](http://hc.apache.org/httpcomponents-client) | 4.3.3 | [Apache-2.0](http://www.apache.org/licenses/) | | [httpcore](http://hc.apache.org/httpcomponents-core-ga) | 4.3.2 | [Apache-2.0](http://www.apache.org/licenses/)
[CC-BY-2.5](http://creativecommons.org/licenses/by/2.5/) | | icu4j-core-mojang | 51.2 | [IBM-ICU](http://source.icu-project.org/repos/icu/icu/trunk/license.html) | | [java-objc-bridge](https://github.com/shannah/Java-Objective-C-Bridge) | 1.0.0 | [Apache-2.0](http://www.apache.org/licenses/) | | jline | 3.5.1 | [BSD-3-Clause](http://www.opensource.org/licenses/BSD-3-Clause) | | [jopt-simple](http://pholser.github.io/jopt-simple) | 5.0.3 | [MIT](http://opensource.org/licenses/mit-license.php) | | log4j-api | 2.17.1 | [Apache-2.0](http://www.apache.org/licenses/) | | log4j-core | 2.17.1 | [Apache-2.0](http://www.apache.org/licenses/) | | lombok | 1.18.32 | BSD-3-CLAUSE-NO-TRADEMARK
[MIT](http://opensource.org/licenses/mit-license.php) | | maven-artifact | 3.5.3 | [Apache-2.0](http://www.apache.org/licenses/) | | plexus-utils | 3.1.0 | [Apache-2.0](http://www.apache.org/licenses/) | | vecmath | 1.5.2 | [GPL-2.0-only](http://www.gnu.org/licenses/gpl-2.0.html)
[ORACLE-OPENJDK-EXCEPTION-2.0](http://openjdk.java.net/legal/gplv2+ce.html) |
Contact Qodana team Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions