CubicMC / cubic-server

A fast and extensible C++ Minecraft server implementation
https://cubicmc.org
GNU General Public License v3.0
53 stars 6 forks source link

Add the feature "Forest Rock" #200

Closed fluffyloafie closed 12 months ago

fluffyloafie commented 1 year ago

https://minecraft.fandom.com/wiki/Forest_rock

This generation is seed-based (size & position)

emneo-dev commented 1 year ago

Looks like the generation is far from being good here ;w;

Also why do I need to go and comment and uncomment pieces of code to test this?

2023-09-02_15 48 58 2023-09-02_15 49 04

fluffyloafie commented 1 year ago

Looks like the generation is far from being good here ;w;

The generation is supposed to be like this. Sometimes the rocks are not all round and perfect. Here is a bunch of test rocks I "placed" in the original game. As you can see, they are pretty much diverse and not round at all. image image image

And this one in its original biome, from the original game generation : image

Also why do I need to go and comment and uncomment pieces of code to test this?

The code is commented for the people who want to test it, as the Forest rock only appears in the Old Taiga biomes, which are not implemented yet.

cloudflare-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5670457
Status: ✅  Deploy successful!
Preview URL: https://d432a203.cubic-server.pages.dev
Branch Preview URL: https://feature-forest-rock.cubic-server.pages.dev

View logs

emneo-dev commented 12 months ago

Ok so you did a rebase but that invalidated all of the signed commits :/ Later we need to avoid rebases if commits are gpg signed as that would directly invalidate the signings.