search

CubicaLabs / IDASynergy

A combination of an IDAPython Plugin and a control version system that result in a new reverse engineering collaborative addon for IDA Pro. By
http://cubicalabs.com/
MIT License
91 stars 18 forks source link

import_function_comments / ValueError: need more than 2 values to unpack #1

Closed nezlooy closed 9 years ago

nezlooy commented 9 years ago

Traceback

...
File "C:\Users\john\AppData\Roaming\Hex-Rays\IDA Pro\IDASynergy\IDASynergyIO.py", line 482, in import_function_comments
    for ea, comment, isRep in comment_list:
ValueError: need more than 2 values to unpack

Diff and patch

--- /tmp/git/IDASynergy/IDASynergy/IDASynergyIO.py        2014-12-01 18:49:44.610691000 +0400
+++ "C:\\Users\\john\\AppData\\Roaming\\Hex-Rays\\IDA Pro\\IDASynergy\\IDASynergyIO.py"     2014-12-02 16:09:08.551779100 +0400
@@ -479,7 +479,7 @@

     @importer(7)
     def import_function_comments(self, comment_list):
-        for ea, comment, isRep in comment_list:
+        for ea, (comment, isRep) in comment_list:
             if isRep == 1:
                 SetFunctionCmt(ea, str(comment), 1)
             elif isRep == 0:
saccoa commented 9 years ago

Oops, fixed it. Thank you for taking the time to report it.