search

Cubitect / cubiomes-viewer

An efficient graphical Minecraft seed finder and map viewer.
GNU General Public License v3.0
1.03k stars 61 forks source link

False positive for woodland mansion in V1.19 #155

Closed mooing-cowmilk closed 2 years ago

mooing-cowmilk commented 2 years ago

Cubiomes says there is a mansion at 0,0 on -1034420513776306998 on 1.19 but there is no mansion in-game

mooing-cowmilk commented 2 years ago

-128071063668497579 is another seed

Cubitect commented 2 years ago

A recent change I made in v2.3.2 that was meant to improve accuracy was implemented incorrectly and essentially made all Mansions incorrect. This should be fixed in v2.4.0.

Cubitect commented 2 years ago

Some related things that I want to point out, although they probably aren't the cause for this issue:

Desert Pyramids, Jungle Temples, as well as Woodland Mansions to a lesser extent, depend on the actual surface height in 1.18+, which cubiomes currently cannot determine. Instead it uses the climate parameters and biomes to estimate the surface height, but that is not always sufficient.

There is now an advanced option to disable terrain checks, which will avoid false negatives at the cost of significantly more false positives.