Cubitect / cubiomes-viewer

An efficient graphical Minecraft seed finder and map viewer.
GNU General Public License v3.0
1.08k stars 62 forks source link

Seed list gives different results sometimes with stronghold distance #176

Closed masterwyatt closed 1 year ago

masterwyatt commented 1 year ago

Basically seed searching for stronghold distance from the spawn i set the centred square side to 1300 and sometimes from the seedlist it pops up 3 seeds for example and then run it again its 2 seeds. Also some seeds have a stronghold thats farther then the distance I set it. Hopefully this is not too vague.

masterwyatt commented 1 year ago

Also to clarify I was searching with this on version 1.18

Cubitect commented 1 year ago

I am not entirely sure I understand. Do you actually get incorrect results, or are you just concerned that the seeds that are found can be different between runs?

A discrepancy can arise for searches that produce seeds very quickly, while also using the "Stop on results" option.

"Stop on results" simply stops the search once any results are found, but since the trial seeds are distributed among the search threads, you will just get the results from the thread that was the fastest. There is not much to be done against this, except limit the search to a single thread.

However, the latest update also introduced a limit on the number of UI updates, and seeds will be buffered for a short time so even with a single thread you can get a different number of results, but the seed values should remain the same.

masterwyatt commented 1 year ago

I was trying to say that both of those things happen. The seed sometimes doesn’t show up, and that the stronghold dist from spawn is completely inaccurate most of the time, if you need a seed for an example I can give you one

Cubitect commented 1 year ago

Yes, I need to know the exact conditions, examples of incorrect seeds, your OS and the tool version, if it isn't the latest. Ideally, just export your session (File > Save session) and attach it here.

Cubitect commented 1 year ago

Closing by assumption this is a non-issue caused by the non-immediate stop.