search

Cubitect / cubiomes-viewer

An efficient graphical Minecraft seed finder and map viewer.
GNU General Public License v3.0
1.02k stars 60 forks source link

Segmentation fault on biome search #200

Open maxsupermanhd opened 1 year ago

maxsupermanhd commented 1 year ago

I want to find some mushroom islands on my seed but upon entering search parameters and clicking on "Analyze" I get segfault.

Steps to reproduce:

  1. Enter seed 7540332306713543803, version 1.12
  2. Set Y to 256 (same with Y63)
  3. Navigate to biomes tab, set current seed and search space -100k, -100k, 100k, 100k
  4. In locate subtab select mushroom fields, area of 128 with 0 border tolerance
  5. Click on analyze and get segfault

Linux Ubuntu 20.04 Compiled from master f8c7ca6 in clean build directory

Cubitect commented 1 year ago

The locate function is not really equipped to handle areas that exceed the signed integer limit in size. It definitely shouldn't crash though and the next version will guard for this and show an appropriate warning.

maxsupermanhd commented 1 year ago

What about making another function that would operate on int64? Or is it just viewer-specific code? (I don't want to be a reason for breaking changes in cubiomes :stuck_out_tongue:)

0x000006 commented 1 year ago

Can confirm, version 3.2.1 win10 x64 downloaded from https://github.com/Cubitect/cubiomes-viewer/releases.