Cubitect / cubiomes-viewer

An efficient graphical Minecraft seed finder and map viewer.
GNU General Public License v3.0
1.02k stars 60 forks source link

[Bug] Extreme Hills, Extreme Hills+, and Extreme Hills M appear as flatlands in 1.18 and 1.19 #205

Open Delvin4519 opened 1 year ago

Delvin4519 commented 1 year ago

Located this bug generating a 1.19 world in game.

Extreme Hills, Extreme Hills+, and Extreme Hills M (Mountains/Wooded Mountains/Gravelly Mountains; Windswept Hills/Windswept Forest/Gravelly Windswept Hills), appear as flatlands at y87 in cubiomes. This is not the case in game.

This only affects these 3 variants of Extreme Hills biomes, and only in 1.18/1.19, and only in cubiomes. All other hills appear correctly in cubiomes for their respective versions. This is still the case even with custom colors/textures turned off, it's still the same bug.

Seed for testing: 1029974796 (v1.18/v1.19)

image image image image

Cubitect commented 1 year ago

Cubiomes currently just checks the depth parameter to determine the height level. This fails to account for some noise and cave generation, and affects more biomes as well, notably the ocean floor. However, it usually gets reasonably close, but the feature is specifically described as an approximation.

Chunkbase seems to do something similar.

Delvin4519 commented 1 year ago

This issue can be noted in the README.MD file that "Windswept Forest/Mountains and Ocean biomes appear as flatlands in the heightmap/depth view in Minecraft versions 1.18 or above/newer". This, then I can close this issue and mark as resolved for now.