search

Cubitect / cubiomes-viewer

An efficient graphical Minecraft seed finder and map viewer.
GNU General Public License v3.0
1.08k stars 62 forks source link

Limit zoom #67

Closed JakobDev closed 2 years ago

JakobDev commented 2 years ago

While playing around I found out that cubiomes-viewer allows infinity zooming out. If you zoom out too much, it will hang. When you close cubiomes-viewer, it will try to load the session and hang, which is a really bad user experience. SO it's the best to limit the zoom factor.

Delvin4519 commented 2 years ago

Not a bad idea, 1:1024 makes sense to restrict zoom level to.

However, that decimal would need to be slightly adjusted to be 1/1024, which is 0.0009765625 instead of 0.001, given that powers of 2 are worked with, not powers of 10.

Cubitect commented 2 years ago

A zoom limit is reasonable, though I actually I kind of like the idea that you can zoom out far enough that you can reach the world border with normal navigation, without jumping. The freezing seems to be caused by QThreadPool since it is not designed for that many runnables. I might add more scaling levels to avoid this issue...