search

Cubitect / cubiomes-viewer

An efficient graphical Minecraft seed finder and map viewer.
GNU General Public License v3.0
1.08k stars 62 forks source link

Quad hut search fails for some (large?) offsets #83

Closed PengolodhGoedath closed 2 years ago

PengolodhGoedath commented 2 years ago

Background: I was searching for seeds with a quad hut with a stronghold in range. I found this example seed 42042210985401 for Minecraft 1.18, which has the desired qualities, from another source. In order to find similar seed, I then played with filters and applied them to this seed for evaluation.

Simple searches for quad-huts worked fine, but to my surprise, when I increased the "within centred square of side" option to 96 (about where the outermost strongholds are able to spawn), the seed was no longer successfully detected.

Some more fiddling revealed that up until (and including) "within centred square of side" = 20 accepts the given seed, whereas a value of 21 no longer does.

Works: grafik

Doesn't work: grafik

Not sure whether this is a bug in cubiomes-viewer or cubiomes, though.

Cubitect commented 2 years ago

The search switches algorithms when the area gets too large to fit into a list in memory. There was a problem with that alternative algorithm that should be fixed now.

PengolodhGoedath commented 2 years ago

Yes, it seems to be fixed in 1.12. Thanks for the quick fix!