[Beta 1.7] Small fringes of rainforest erroneously generating around tundra biomes

Cubitect / cubiomes

C library that mimics the Minecraft biome generation.

MIT License

579 stars 104 forks source link

[Beta 1.7] Small fringes of rainforest erroneously generating around tundra biomes #91

Closed KaiSandstrom closed 1 year ago

KaiSandstrom commented 1 year ago

This bug was caused by one of the changes made to the master branch between PR #87 and PR #90. The first image below was created in my fork using the same code submitted for #90. The second was created after syncing the fork with origin master and recompiling. The third image shows the difference.

I haven't thoroughly dug into the changes, but I suspect this was caused by the changes in biome_tree.c to getOldBetaBiome() and the Beta 1.7 biome lookup table.

fringepre fringepost fringediff

Cubitect commented 1 year ago

My bad. I rearranged the biome ID mapping to an ascending order but made a mistake with the substitution. I'm surprised that I didn't get a warning from my testing code that the output had changed...

KaiSandstrom commented 1 year ago

That did the trick