search

Cuis-Smalltalk / Cuis-Smalltalk-Dev

Active development of Cuis Smalltalk
MIT License
435 stars 70 forks source link

Saving a message with an unknown selector within messes up the code. #152

Closed alesch closed 5 years ago

alesch commented 5 years ago

When saving a message with an unknown selector, the browser correctly asks for correction or confirmation.

Depending where the cursor is placed when invoking the Save operation, a wrong portion of the code is selected. Thus upon confirmation, the selection is replaced with the confirmed method, messing up the code.

Here, if the cursor is placed at the beginning or end of banana, then the selection is correct. Placing the cursor at the end of the message triggers the wrong selection.

This is happening on Cuis5.0-3699.

wrong selection messedUpCode

jvuletich commented 5 years ago

Just do "World / Changes... / Install New Updates". This was fixed a couple of weeks ago.

alesch commented 5 years ago

I did that and I still get the same behaviour.

same

hernanwilkinson commented 5 years ago

Hi Alex, are you still having this problem? Did you do a pull of the repo before installing the changes?

On Thu, May 23, 2019 at 5:37 PM Alex Schenkman notifications@github.com wrote:

I did that and I still get the same behaviour.

[image: same] https://user-images.githubusercontent.com/533044/58284608-41e64380-7dab-11e9-9861-e619064cd785.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/issues/152?email_source=notifications&email_token=AAAOJ547SERGCO6DWK4T2D3PW357PA5CNFSM4HPJF3UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWDNK3I#issuecomment-495375725, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAOJ5YNYEFUVFLK5JESADTPW357PANCNFSM4HPJF3UA .

--

Hernán WilkinsonAgile Software Development, Teaching & Coaching Phone: +54-011-4893-2057 Twitter: @HernanWilkinson site: http://www.10Pines.com http://www.10pines.com/ Address: Alem 896, Floor 6, Buenos Aires, Argentina

alesch commented 5 years ago

Juan helped me. Thank you. I did a git pull and updated the image.

Sent on the go. Please excuse brevity and typos.

On Mon, May 27, 2019, 20:17 Hernan Wilkinson notifications@github.com wrote:

Hi Alex, are you still having this problem? Did you do a pull of the repo before installing the changes?

On Thu, May 23, 2019 at 5:37 PM Alex Schenkman notifications@github.com wrote:

I did that and I still get the same behaviour.

[image: same] < https://user-images.githubusercontent.com/533044/58284608-41e64380-7dab-11e9-9861-e619064cd785.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/issues/152?email_source=notifications&email_token=AAAOJ547SERGCO6DWK4T2D3PW357PA5CNFSM4HPJF3UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWDNK3I#issuecomment-495375725 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAAOJ5YNYEFUVFLK5JESADTPW357PANCNFSM4HPJF3UA

.

--

Hernán WilkinsonAgile Software Development, Teaching & Coaching Phone: +54-011-4893-2057 Twitter: @HernanWilkinson site: http://www.10Pines.com http://www.10pines.com/ Address: Alem 896, Floor 6, Buenos Aires, Argentina

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/issues/152?email_source=notifications&email_token=AAECENHOGUAPEKNCKNSYZZLPXQQT3A5CNFSM4HPJF3UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWKKAKY#issuecomment-496279595, or mute the thread https://github.com/notifications/unsubscribe-auth/AAECENCXA5WH42B54LFZO3LPXQQT3ANCNFSM4HPJF3UA .