search

Cuis-Smalltalk / Cuis-Smalltalk-Dev

Active development of Cuis Smalltalk
MIT License
458 stars 72 forks source link

WebClient not working #171

Closed mmontone closed 3 years ago

mmontone commented 4 years ago

WebClient points to some Monticello code that does not make sense in Cuis, and WebClient doesn't work.

https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/blob/61973629fe5855267df6479040e9b2d03eae02a9/Packages/Features/WebClient.pck.st#L8529

What to do?

mmontone commented 4 years ago

I think we can remove the references to mcVersion method and construct the UserAgent without it

https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/blob/61973629fe5855267df6479040e9b2d03eae02a9/Packages/Features/WebClient.pck.st#L3948

nmingotti commented 3 years ago

As of today the following works

Feature require: 'WebClient'. 
(WebClient httpGet:'http://www.google.com') content.

I would close this issue. It is true there is a reference to Monticello, but seems harmless.

jvuletich commented 3 years ago

I assume it works correctly now.