search

Cuis-Smalltalk / Cuis-Smalltalk-Dev

Active development of Cuis Smalltalk
MIT License
433 stars 71 forks source link

added two fonts to demonstrate the problem and a change set with the fix #229

Closed coderocket closed 2 years ago

coderocket commented 2 years ago

Hi,

I've run into trouble loading some true type fonts. The fonts load OK everywhere else, so I assume it is an actual bug. It appears that there is a special sentinel segment that TTFontReader tries to read as a regular segment. I've changed the code to fix the problem and now the fonts load OK. I've also checked that the change does not affect existing fonts.

I've attached a zipped archive with the change-set. You can also see it in the fork. I've also added the troublesome fonts under the TrueTypeFonts folder so you can reproduce the problem and see that the fix solves it.

Cheers, David ChangeSet.zip

jvuletich commented 2 years ago

Thanks David. I took your changes and sample TTFs from here, and updated the VectorGraphics package. Skipping the "end of search" segment is ok, but the other fix I did differently. Updates already pushed. In the future, please email changesets and anything else to the Cuis list or to me, as we prefer to review contributions prior to merging them. Thanks again!

coderocket commented 2 years ago

Sure, I'll email the changeset next time. Cheers :)

On Thu, 12 May 2022 at 20:58, Juan Vuletich @.***> wrote:

Thanks David. I took your changes and sample TTFs from here, and updated the VectorGraphics package. Skipping the "end of search" segment is ok, but the other fix I did differently. Updates already pushed. In the future, please email changesets and anything else to the Cuis list or to me, as we prefer to review contributions prior to merging them. Thanks again!

— Reply to this email directly, view it on GitHub https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/pull/229#issuecomment-1125275034, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADDMFJCEVIAF23CSQLHWF3VJVBDVANCNFSM5VYP26JA . You are receiving this because you authored the thread.Message ID: @.***>

-- Dr David Faitelson Afeka Te- Aviv Academic College of Engineering