Cuizhiyong / vopenlayers

Automatically exported from code.google.com/p/vopenlayers
0 stars 0 forks source link

Vaadin widgetset update mechanism interferes with widgetset definition in jar #34

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. create a project that inherits from VolWidgetset
2. embed your own hosted version of OpenLayers.js
3. compile the widgetset (e.g. in eclipse)

What is the expected output? What do you see instead?

The compiled widgetset will always contain the VolWidgetsetWithHostedScript 
widget instead, as it is the one defined in the MANIFEST. The vaadin plugin 
will always override the widgetset definition as it does not find VolWidgetset 
in the manifest.

What version of the product are you using? On what operating system?

the latest version 0.9.0, but the same problem should occur in prior versions

Please provide any additional information below.

As a local workaround I created a custom version of the addon with VolWidgetset 
defined in the manifest.

It would be nice to provide two separate versions of the addon, one with the 
possibility to host the OpenLayers.js script yourself and one with the original 
script hosted at openlayers.org

Original issue reported on code.google.com by thomas.n...@gmail.com on 17 Oct 2011 at 9:46

GoogleCodeExporter commented 9 years ago
Hi,

I think we should create an enhancement ticket to dev.vaadin.com about the 
issue.

In the mean time, you could add a following comment the your widgetset:

    <!-- WS Compiler: manually edited -->

With it Vaadin tools will skip updating the widget set. Just note that when 
adding yet another add-on to you project, you will need to add inherits rules 
manually or temporary remove the "manually edited" comment.

cheers,
matti

Original comment by matti.ta...@gmail.com on 17 Oct 2011 at 11:09

GoogleCodeExporter commented 9 years ago
Thanks for the hint, this should solve the problem for me!

cheers,

Thomas

Original comment by thomas.n...@gmail.com on 18 Oct 2011 at 7:09

GoogleCodeExporter commented 9 years ago
Somehow it didn't work for me. I can't use "<inherits 
name="org.vaadin.vol.VolWidgetset" />" with my own openlayers js hosted on 
local server, as described in http://code.google.com/p/vopenlayers/wiki/Using.

If I put "<!-- WS Compiler: manually edited -->" vopenlayers widgets won't 
compile in.

So still ended using hosted from openlayers site. This is quite inconvenience 
as sometime openlayers server down or quite a slow connectivity to my end. :(

Original comment by victorli...@gmail.com on 29 Mar 2012 at 11:31

GoogleCodeExporter commented 9 years ago
i've got this work around by adding into manifest file. just modify/add 
pom.xml, around line 48. then rebuild jar.

<!-- Comma-separated list of widgetsets in the package -->
<Vaadin-Widgetsets>org.vaadin.vol.VolWidgetset,org.vaadin.vol.VolWidgetsetWithHo
stedScript</Vaadin-Widgetsets>

Original comment by victorli...@gmail.com on 28 May 2012 at 9:24