Culley-Studios / ProQuests-Documentation

The most customizable and immersive quest plugin.
1 stars 2 forks source link

FISH_QUEST | Catching drop works #241

Closed Melowelsa closed 5 years ago

Melowelsa commented 5 years ago

Spigot account :https://www.spigotmc.org/members/__melowelei__.378949/

Plugin version : ➥ ProQuests : 2.1.1.3.1

Spigot Version : ➥ git-Spigot-596221b-9a1fc1e (MC: 1.12) (Implementing API version 1.12-R0.1-SNAPSHOT)

Information : ➥ Bug : We can finish "FISH_QUEST" by taking a fishing rod and catching a drop, it count as fished. ➥ Reproduce : Drop an item in front of you, take your fishing rod and right-click the drop.

JCulley commented 5 years ago

Please provide your log file and a detailed explanation. I don't really understand what the issue is as it wasn't described in a detailed manor.

Melowelsa commented 5 years ago

Startup log :http://hatebin.com/lhkwqaubzjGIF :https://gph.is/2RSh1A0

JCulley commented 5 years ago

I would need your log file up until the point the issue occurs. ProQuests simply listens for the fishing event provided by Spigot if it interprets fishing for an entity itemstack to be a valid catch there’s not much I can do.

Melowelsa commented 5 years ago

http://hatebin.com/zshepiocwh.

JCulley commented 5 years ago

I've implemented a workaround so all catches are only counted if the block below the hook is water. This will be in the next release.

JCulley commented 5 years ago

https://www.spigotmc.org/resources/proquests-1-7-1-13-2-20-off-spring-sale-give-players-objectives.18249/update?update=270376