search

CultivateLabs / storytime

Storytime is a Rails 4+ CMS and blogging engine, with a core focus on content. It is built and maintained by @cultivatelabs
MIT License
752 stars 81 forks source link

Bootstrap compatibility fix #179

Closed andyattebery closed 9 years ago

andyattebery commented 9 years ago

Changed Sprockets Bootstrap require to bootstrap-sprockets so if host app also uses Bootstrap, it won't be included twice.

dvanderbeek commented 9 years ago

Somehow this change seemed to break Apex. I had to remove //= require bootstrap from application.js, otherwise the js was included twice (once as bootstrap, once as bootstrap-sprockets) and it made things like the navbar dropdown stop working

bcroesch commented 9 years ago

I wonder if there's some way to conditionally require a js asset? So that we can check if bootstrap has already been required by sprockets and not include it again if so. Will make a note to look into that.