CultureHQ / add-to-calendar

A small package for adding an event to a calendar.
https://engineering.culturehq.com/add-to-calendar/
MIT License
44 stars 26 forks source link

Yahoo Calendar date not correct #597

Open pdkn opened 3 years ago

pdkn commented 3 years ago

pass in a start date of '2021-09-12T11:30` will give a yahoo link similar to https://calendar.yahoo.com/?v=60&view=d&type=20&title=A%20Event&st=20210912T103000Z&dur=0000

new Date('2021-09-12T10:30:00Z') correctly resolves to Sun Sep 12 2021 11:30:00 GMT+0100 (British Summer Time)

but the yahoo calendar sets the event time to 10:30 ( not 11:30 ). The same time format works for all other calendars. This seems to be a bug in Yahoo Calendar api? Just checking if you concur?

YakinRojinegro commented 3 years ago

Following yahoo doc seems that way. Since I got on my timezone the proper time and also having it on 10:30 on yahoo calendar. Also with the Z at the end should take the users datetime but it is actually taking it as local. https://github.com/InteractionDesignFoundation/add-event-to-calendar-docs/blob/main/services/yahoo.md#st

pdkn commented 3 years ago

thanks @YakinRojinegro - it looks like Yahoo calendar is broken at moment so I'll have to rip it out