search

Cumulus / Syndic

RSS and Atom feed parsing
MIT License
34 stars 13 forks source link

Test suite #56

Closed dinosaure closed 9 years ago

dinosaure commented 9 years ago

I think it's good for a start. The code is not super readable but it did its job. If you have any comments @Chris00, do not hesitate. I use the API W3C whether Syndic reason to reject a document or we have a problem of implementation.

For now, there is only one test with OCaml. But you can complete (I do not have a big base of flow).

dinosaure commented 9 years ago

And the OCaml is not valid :confused:.

Chris00 commented 9 years ago

I did not have time to read it in details yet but I like the idea.

We may want that decisions like the Atom.link title one come together with a corresponding W3C test.

Chris00 commented 9 years ago

And the OCaml is not valid

The remaining problem is the URN scheme not being supported by Uri. (Other problems are fixed I think — but I have not yet updated Syndic on the server but the commits > version 1.3 aim to fix the W3C reported issues). This should be fixed in Uri 1.9 and I intend to make Syndic require it once it will be released.

Chris00 commented 9 years ago

I checked the code and made a few modifications that I will push soon. There is something that still puzzles me: if I understand the intention, the test program is supposed to use the W3C validator to check that when the library reject some feed, so does the validator. However, the result of make_test (src, fmt, result) is not used at all...