Open aderumier opened 3 years ago
Hi @aderumier
We are finalizing a Cumulus release cycle, hence the low activity here on github. A couple weeks ago I pushed some of my recent changes. I will push the rest of it next week and i'll make a debian submission.
Have you been testing master on proxmox?
Hi @aderumier
We are finalizing a Cumulus release cycle, hence the low activity here on github. A couple weeks ago I pushed some of my recent changes. I will push the rest of it next week and i'll make a debian submission.
ok thanks !
Have you been testing master on proxmox?
Not yet, I was waiting for a new release first, but as proxmox beta 7.0 has just been released, I'll try to test ifupdown2 master asap now. (The plan is to release proxmox7 when debian11 will be release, to at the end of the summer I think).
Hi @aderumier
I just finished porting our private commits. Let me know how testing goes on Proxmox :) Here is the full list that I just pushed to master:
c2b847f7afc3f45524973662f78f2cc76a2bc507 addons: introduces old_ifaceobjs to get_dependent_ifacenames 15666526bf21f72da33b781efb06fc60601d5e83 usercmd: fix TypeError: unsupported operand type(s) for |: '_Environ' and 'dict' a1d6115e35e8c939273c9a9b38fc38eea5580a9d debian: changelog: new 3.1.0-1 entry acfdbff8918655a9fa9f18b023e08006dde58779 nlcache: clean duplicated code (link_add) b334df6e88b2c129ecc83e998152a257e73064dc nlcache: update link_set_bridge_info_data_dry_run 9a6a305084e27901c1927842909c2534db47051f cleanups - upstream sync ba5437b9ecf9aa1401ac985ebf97009cc3114481 nlcache: addr_add: convert pointtopoint and broadcast attribute to ipaddress obj f8ed376891b898166355ba1bdd23873e97f1614e lib: nlcache: new netlink API "link_add" (waits for link creation) 790a55e93e2e88e5c1ab2cdd9371ed348da2e6b7 addons: link: ifquery-check now validates admin state 859b8643b625e2bf9dd6fe0a2186f450e6f7e223 nlcache: link_set_address: override cache after mac address change is aacked 9b23b7c684ce54e4763cbe1a88eb66731238e2db iproute2: svd: convert vnifilter attr to boolean to cover all case 9ca87c5e8b0389bc2d42b92287a050b32c116e83 addons: vxlan: ifquery-check: mcastgrp-map: use bridge vni show 3376c2333562fcf01bceb05fbf417fd03efda914 addons: vxlan: remove stale code (bridge fdb show call) b3a93dfce17da366c321191fe829ca1880323e5e addons: vxlan: fix name 'vni_mcastgrp_map' is not defined d910b87c50e7221bb7d47ac7d52bf448d366deb6 addons: vxlan: mcastgrp-map: remove validval attribute e7ecab23d9a5e232940289830ee85e4fda6947fc addons: vxlan: refactoring code to allow updating an existing SVD 20aabf550ce4a3aec9471482151d3c2369104f8a addons: vxlan: fix mcast group get api during vni filter set 238e0485078828462ae65374c1babc418816e8ce addons: vxlan: remoteip-map: check user config against old config and not running state d4403f1e77800d9d19c6a8bb241f207fc2443844 addons: vxlan: ifquery-check: don't check fdb running state if mcastgrp-map or remoteip map are not configured 2b867068c69ed6a27967578fd05723f1a825e0b7 addons: vxlan: allow svd config update 8743434a253fb82e069c08dab7d0ec1dab6a84eb addons: vxlan: add null list check when mcastgrp map not present 782aff35ceff3174154bb10b9377cf3b96df33b7 addons: vxlan: support for vxlan-support-mix-dev-types policy (default yes) db4371de3c3f66087a5c1dec471174d9e8baeb52 addons: vxlan: error out when an unsupported mix of SVD and TVDs are configured eff66130236992cd47cbb163eea3e4bc33e138ec lib: iproute2: fix missing bridge_vni_del function abb7644b9cbb775eae0942ea3ee327d90928f4db lib: iproute2: batch vni filter commands af8d5db22b10909ff06032f1a2acc2f745d1f65b addons: vxlan: use new vni filter api to set mcast groups per vni 8acbc3c523cb7d4a329e7dc0fbcd7ee38971a28c ifupdown2: lib: dont bring down link during vni filter changes 1b7f1f34e4c219236e54d46ec873e39208ad3fd2 addons: vxlan: add 'Exception' to try/catch e79cf84297571b66747f74d443fc0316893eedb0 addons: bridge-vlan-vni-map: add vlan reserved check ec5fde253274a9a771e5c6305e13cf6b67ede601 addons: bridge: bridge-vlan-vni-map: add more details log error when finding duplicated vnis af3034111fe27dc951b88f98c316e62e1954f04a addons: bridge: bridge-vlan-vni-map: fix consecutive vni ids mapped to incorrect range vids 13ecedd2f7a7d0baa1ff54d2f996e0565a0b8982 addons: bridge: add batching commands for vids add/del 2ac257faeddd964c2b7bba0401e7a85498e917f8 addons: bridge: fix bridge-vlan-vni-map range processing 905003dd25060a459f6cf866c245e3ce4f00b635 addons: bridge: bridge-vlan-vni-map: fix delta calculation between old and new config 06926b19799f24a2cbcc986257e2e8589f5f1f3f addons: bridge: bridge-vlan-vni-map: remove stale entry from running config 19b0c19bdfa198ad8d175b80af9d3f1ad43f96e7 addons: bridge: don't add old_ifaceobjs to internal MVAB list 995c38e29a72688672bbc88bcb029cc3a80f50d6 addons: bridge: bridge_vlan_aware_list is now a set() c38ff73d90edd55f43a49c839f84f13864716b88 lib: iproute2: add vxlan bridge default fdb entries with state permanent f3229eecaab2e4004f105619c5e0c43edc8c54f8 lib: iproute2: use self flag when adding svd fdb entries 0cb747dd9e30787a773198b515a340c17b2aebf8 iproute2: link_set_address: dont check the cache on link up 66eb9ce3c5ab4806817281aa7371ace68ed48a3e addons: vxlan: add support for new attribute: vxlan-remoteip-map 8e167b9e32730f311da6ab97e573bc7b37e4d176 addons: vxlan: process mcast groups after the addition of vnifilter 7f0310a7a584b69ab05f99e75c9c7fb6711cee4d bridge: support values of auto, auto+, auto- for vni in bridge-vlan-vni-map e6edcd2113b5293812dcb076f0852851c19e0348 addons: vxlan: ifquery-check support for vxlan-mcastgrp-map 9144496d013bbbfadb93fa4b359a39f8b4212c20 vxlan: fix ttl for single vxlan device 6015cce25b90e79be9285aee129fcab4bb4e5c2c addons: vxlan: add support for vni/IP range and multi lines on SVD mcast group config 84c47c4ff053009056f824702fcd1f0caf115762 addons: vxlan: add support for vni filter on single vxlan device 56f3434979b8bed3c2889f105df4cb8c68d8acd2 addons: vxlan: improve mcastgrp-map handling of fdb entries 1609696fe37d612d17eeee9d56459ccb0d296c37 addons: vxlan: add support for vxlan-mcastgrp-map with ipmr-lo dummy physdev aa4c8a2d9484a31773ed9c600926c348f69b01ee addons: vxlan: single-device: update log.warning when device already exists 8515db27339194370e35818bf8678837da23b213 addons: bridge: bridge-vlan-vni-map: use vlan and vni ranges within iproute2 cmds 8b99615b830daf7edf27cfb4d49fe0f757df955a addons: bridge: add multi bridge support when bridge_set_static_mac_from_port=yes 31bddf7647f3e9c916d1fd9831d85cc9d82acb11 addons: bridge: bridge-vlan-vni-map: fix display error vnis=vlans instead of vlans=vnis d42c5f307e62954b20e99916c84ee00a580f38ee addons: bridge: ifquery-running support for bridge-vlan-vni-map b2751c6f577dba10d14572e0edb3080f4493a4f0 addons: bridge-vlan-vni-map: support multiple vni mapping per entry f422ae7c6c6b281b1d3d217d635deb9f09952e03 addons: bridge: bridge-vlan-vni-map: fix: not enough arguments for format string f54468e32b8bbb5732342d233b9cb74b2cb5a829 addons: bridge: check if bridge mac is already inherited from a port ecb7cc1365b3e02d29d3daef959518374497e2c8 addons: bridge: bridge-arp-nd-suppress should show up on ifquery --with-default if policy is set 4b16a997971c223aef9b9f1279c19dbe029788d5 clag: bridge l3vni: move bridge vxlan l3vni code to parent class + refactoring 68d0005516aff334149d2963d431aae89483be71 bridge.py: remove extra empty line in header 32ef3071ecf8106852838c3bea6f2ce94056ca05 addons: bridge: fix bridge arp vni vlan syntax-check 3e5e36410e25318057aaad397e7f8c47876dc0fb addons: bridge: v2: arp suppression enabled when no vlan is configured 645fcb73e2ac32a38b66f5158459301524802334 addons: bridge: skip bridge arp vni vlan for single vxlan device a037ffc5f098c850ea69f9e0b7756fae514aae44 addons: bridge: detect and warn when arp suppression is enabled and there is no vlan configured 6a1110e3ed7c69241b6eb02ec566415c28aba4f8 addons: bridge: detect VXLAN mis-config VNI "bridge-learning=on" and print log message 20649b09c641b86bcf95127927134074d7014490 addons: bridge: enable ipv6 on SVD brport 35dabe6adda58007dc22d57f0441c7e0cf662d0b cosmetic: ifupdownmain: remove empty line (pep8) 3b1f78c181e86a3351ec2f0a08ecf8a9e0a1d79b ifupdownmain: add "all" parameter to get_all_ifaceobjs 20e8d38375e9f51616b1a45f4c5854a7b8ceb9a3 ifupdownmain: skip bridge vlan when checking running config e3dbe405ba9b279cc0a0ce1f0b6d5b1222824bb4 ifupdownmain: add module name in get_dependent warning 59ab29fbd1604f5a63ea9a2e4e1c2b432c6bbbb1 addons: vxlan: inherit clagd-vxlan-anycast-ip from lo for clag vxlans (introduces old_ifaceobjs to get_dependent_ifacenames) 1db0cb7accbf7cbb813d4276e00f79925f1798b4 addons: address: remove stale fdb entry for svi (when hwaddress is used) 20eab2b13e033fa7d52a539b563f4462cf3b1d0a addons: address: new policy: check_l3_svi_ip_forwarding 0b34071bf8e15104ee470daed684ff75521d2c83 addons: address: warn user if L3-SVI is configured with "ip-forward off" 9c1176c8499c7f2cdc94667263262bfbb155f76b addons: vlan: check vlan-id misconfiguration and print warning 75a95030271dd5ca3d3af87a55793b45702656a7 addons: addressvirtual: check macvlan interface name lenght and war if len > 15 01a655366bbca01ed7cd3a7bd7ffb4c1cd314f84 addons: address: raise exception when detecting an invalid ip address
Thanks Julien. Proxmox 7.0 has just been release today, I'll try to the last patches soon and try to push it asap in proxmox 7.1
@julienfortin
3.1 has been push to proxmox repo, seem that we have a regression with pointopoint interface, I think because of this commit: https://github.com/CumulusNetworks/ifupdown2/commit/ba5437b9ecf9aa1401ac985ebf97009cc3114481
auto vmbr0
iface vmbr0 inet static
address xxx.xx.3.186
netmask 255.255.255.255
gateway xxx.xx.3.129
pointopoint xxx.xx.3.129
bridge-ports enp193s0
bridge-stp off
bridge-fd 0
vmbr0: cannot add address xxx.xx.3.186/32 dev vmbr0: argument of type 'IPNetwork' is not iterable
with full debug
File "/usr/sbin/ifup", line 131, in <module>
sys.exit(main())
File "/usr/sbin/ifup", line 119, in main
return stand_alone()
File "/usr/sbin/ifup", line 103, in stand_alone
status = ifupdown2.main()
File "/usr/share/ifupdown2/ifupdown/main.py", line 77, in main
self.handlers.get(self.op)(self.args)
File "/usr/share/ifupdown2/ifupdown/main.py", line 193, in run_up
ifupdown_handle.up(['pre-up', 'up', 'post-up'],
File "/usr/share/ifupdown2/ifupdown/ifupdownmain.py", line 1835, in up
ret = self._sched_ifaces(filtered_ifacenames, ops,
File "/usr/share/ifupdown2/ifupdown/ifupdownmain.py", line 1558, in _sched_ifaces
ifaceScheduler.sched_ifaces(self, ifacenames, ops,
File "/usr/share/ifupdown2/ifupdown/scheduler.py", line 588, in sched_ifaces
cls.run_iface_list(ifupdownobj, run_queue, ops,
File "/usr/share/ifupdown2/ifupdown/scheduler.py", line 318, in run_iface_list
cls.run_iface_graph(ifupdownobj, ifacename, ops, parent,
File "/usr/share/ifupdown2/ifupdown/scheduler.py", line 308, in run_iface_graph
cls.run_iface_list_ops(ifupdownobj, ifaceobjs, ops)
File "/usr/share/ifupdown2/ifupdown/scheduler.py", line 181, in run_iface_list_ops
cls.run_iface_op(ifupdownobj, ifaceobj, op,
File "/usr/share/ifupdown2/ifupdown/scheduler.py", line 102, in run_iface_op
m.run(ifaceobj, op,
File "/usr/share/ifupdown2/addons/address.py", line 1401, in run
op_handler(self, ifaceobj,
File "/usr/share/ifupdown2/addons/address.py", line 1036, in _pre_up
self.process_addresses(ifaceobj, ifaceobj_getfunc, force_reapply)
File "/usr/share/ifupdown2/addons/address.py", line 608, in process_addresses
self.__add_ip_addresses_with_attributes(ifaceobj, ifname, user_config_ip_addrs_list)
File "/usr/share/ifupdown2/addons/address.py", line 527, in __add_ip_addresses_with_attributes
self.log_error(str(e), ifaceobj)
File "/usr/share/ifupdown2/ifupdownaddons/modulebase.py", line 108, in log_error
traceback.print_stack()
Traceback (most recent call last):
File "/usr/share/ifupdown2/lib/nlcache.py", line 3175, in addr_add
peer = ipnetwork.IPAddress(peer)
File "/usr/share/ifupdown2/nlmanager/ipnetwork.py", line 145, in __init__
elif "/" in ip:
TypeError: argument of type 'IPNetwork' is not iterable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/share/ifupdown2/addons/address.py", line 517, in __add_ip_addresses_with_attributes
self.netlink.addr_add(
File "/usr/share/ifupdown2/lib/nlcache.py", line 3193, in addr_add
raise NetlinkError(e, "cannot add address %s dev %s" % (addr, ifname), ifname=ifname)
(reverting +peer = ipnetwork.IPAddress(peer) fix it)
@aderumier thanks for reporting the regression! 1bb6e6f0fba446f21c0af07e289b33211ff0dc05
Friendly inquiry on the current state. Debian sid/unstable still includes 3.0.0-1.
Does 3.1.0-1
get a git tag in this repository? (latest tag:3.0.0-1)
Hi, I would like to known if a new minor release will come soon ?
we are still at 3.0 since september, and a lot of commits are in master.
(I'm looking to upgrade ifupdown2 for the next proxmox 7.0, as ifupdown2 will be used by default :)