CumulusNetworks / ifupdown2

GNU General Public License v2.0
161 stars 75 forks source link

scheduler: import traceback #267

Closed aderumier closed 1 year ago

aderumier commented 1 year ago

if a script in /etc/network/ifup.d/ is segfaulting,

on config loading (ifup -a), ifupdown2 is stopping

ifup -a " info: executing2 /etc/network/if-up.d/postfix debug: lo: up : running script /etc/network/if-up.d/resolved info: executing2 /etc/network/if-up.d/resolved error: name 'traceback' is not defined debug: saving state .. info: exit status 1 "

with this fix:

debug: lo: up : running script /etc/network/if-up.d/resolved info: executing2 /etc/network/if-up.d/resolved File "/usr/share/ifupdown2/ifupdown/scheduler.py", line 325, in run_iface_list cls.run_iface_graph(ifupdownobj, ifacename, ops, parent, File "/usr/share/ifupdown2/ifupdown/scheduler.py", line 315, in run_iface_graph cls.run_iface_list_ops(ifupdownobj, ifaceobjs, ops) File "/usr/share/ifupdown2/ifupdown/scheduler.py", line 188, in run_iface_list_ops cls.run_iface_op(ifupdownobj, ifaceobj, op, File "/usr/share/ifupdown2/ifupdown/scheduler.py", line 150, in run_iface_op ifupdownobj.log_error('%s: %s %s' % (ifacename, op, str(e))) File "/usr/share/ifupdown2/ifupdown/ifupdownmain.py", line 226, in log_error raise Exception(str) error: lo : lo: up cmd '/etc/network/if-up.d/resolved' failed: returned -11 debug: vmbr0: found dependents ['bond0'] debug: bond0: found dependents ['enp65s0d1', 'enp65s0'] info: enp65s0d1: running ops ... ... ...

aderumier commented 1 year ago

@julienfortin thanks! (proxmox8 has been released with last ifupdown2 version, so I begin to see bug reports, so maybe I'll have other patches soon ^_^)

julienfortin commented 1 year ago

@aderumier sounds good, thanks for always sending your patches! I know I still have a few to review/merge. 😅

aderumier commented 1 year ago

I should have more users return about my ipv6 slaac soon. (the patches are already applied in proxmox ifupdown2 packages)