search

Cuperino / QPrompt-Teleprompter

Teleprompter software for all video creators. Built with ease of use, productivity, control accuracy, and smooth performance in mind.
https://qprompt.app
GNU General Public License v3.0
357 stars 23 forks source link

Text decorations not applying #93

Closed videosmith closed 2 years ago

videosmith commented 2 years ago

Bug Description Unable to apply text decorations (size, underline, etc.) through contextual menu

Steps to Reproduce

  1. Load the default script
  2. Select some text
  3. Right-click on the selected text and select Font...
  4. Adjust size or underline.

Expected behavior Font decorations should apply to selected text.

Detailed description of display configuration (if applicable) qprompt-v1.0-2c9752c-v1.0-linux-64-gcc.AppImage

specs

Cuperino commented 2 years ago

This is a duplicate of issue #25.

The font dialog is shown is provided by the OS or the desktop environment in the case of Gnome, Plasma, Windows, and macOS. I can only choose what to do with the information received from the dialogs, but I cannot do much about the dialogs themselves. Changing font sizes from this dialog has the potential of breaking how the font slider works, which is why that setting is ignored.

What I plan on doing is create my own dialog and replace the native dialogs with it. This is a low priority item that involves a considerable amount of work. The ideal solution is improve Qt's font dialog code upstream, so that it allows for more granularity on which fields are to be shown. To effectively do that, both KDE Frameworks and QPrompt first need to complete the transition to Qt version 6.

videosmith commented 2 years ago

The font slider works great.... however it affects all the text simultaneously. Occasionally a client would like specific text at a different size (emphasis, readability etc.), so that ability would be nice to have.

Cuperino commented 2 years ago

Occasionally a client would like specific text at a different size (emphasis, readability etc.), so that ability would be nice to have.

The issue with having text of different sizes is that it can screw with QPrompt's ability to estimate the presenters' desired reading speeds. This is a feature that I've been planning since the start, but is still awaiting for groundwork to be completed before it's actually implemented. Discussion about that can be found at #19.

Cuperino commented 2 years ago

I also thought about giving the option anyway and compensate for it using math, but the other problem that we have is that Qt's subset of HTML and CSS used in editor is much more limited than that of a web browser, which means the relative em unit used to achieve this in Imaginary Teleprompter is not available to us, and there's no easy way to allow assigning text size without breaking font scaling for those lines.