search

Cuprate / cuprate

Cuprate, an upcoming experimental, modern & secure monero node. Written in Rust
Other
122 stars 17 forks source link

Add `constants/` crate #280

Open hinto-janai opened 2 weeks ago

hinto-janai commented 2 weeks ago

What

Adds a cuprate_constants crate in the root constants/ folder.

Closes https://github.com/Cuprate/cuprate/issues/189.

Why, where

See #189.

How

See below review.

Asurar0 commented 2 weeks ago

Will P2P constants be included in this crate as well?

https://github.com/Cuprate/cuprate/blob/main/p2p/p2p-core/src/constants.rs https://github.com/Cuprate/cuprate/blob/main/p2p/p2p/src/constants.rs

hinto-janai commented 2 weeks ago

Will P2P constants be included in this crate as well?

I haven't checked in depth but if they are pub(crate) and not needed elsewhere, probably not. Constants like CRYPTONOTE_MAX_BLOCK_HEIGHT doesn't really belong anywhere yet is needed by multiple crates - these are the type of constants this crate will contain.